From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2AD5C433EF for ; Tue, 28 Jun 2022 02:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242829AbiF1CaB (ORCPT ); Mon, 27 Jun 2022 22:30:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244837AbiF1C2K (ORCPT ); Mon, 27 Jun 2022 22:28:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7578824F33; Mon, 27 Jun 2022 19:26:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2129DB81C10; Tue, 28 Jun 2022 02:26:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D626C341CD; Tue, 28 Jun 2022 02:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656383200; bh=kzysqwDMbrFD0UY5/4UstAflvUENFFYhyZj8oCNQ1yQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X7sGDU4rB2J0v79xKyj6NL2UfEDPGl7V65FQ7XJj/z8p9GMg+9pe7+qqc5FyVfB3P rPKoapnVaQUYhjcPPlDXzmQLciZUPEpMZr2LZeVV7MLD5fCa3JhD9KIGlyM6fgacZM eb/vaYj0EUJdI/CuBLvKBJ9x4qUqEPI0aUjUKj6lXhnmyTF3WzAD1LZCEkdApPlpji y7B4XINNPRM/duq20DYEmK5bIwjpGr18gVcb4D8VBKscx0xGcjdIkpdkC4eg1YB/G3 7b2E0RwgMsKBIYWp5hPOgv3RK+JEmvto0dpPDY/dXtDR5bsDH0QX811J1N1BO1stOy omJmNtuSt53/A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yihao Han , Hans de Goede , Helge Deller , Sasha Levin , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.14 10/17] video: fbdev: simplefb: Check before clk_put() not needed Date: Mon, 27 Jun 2022 22:26:08 -0400 Message-Id: <20220628022615.596977-10-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022615.596977-1-sashal@kernel.org> References: <20220628022615.596977-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org From: Yihao Han [ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ] clk_put() already checks the clk ptr using !clk and IS_ERR() so there is no need to check it again before calling it. Signed-off-by: Yihao Han Reviewed-by: Hans de Goede Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/simplefb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index a3c44ecf4523..b7ad20ff8d2a 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -233,8 +233,7 @@ static int simplefb_clocks_get(struct simplefb_par *par, if (IS_ERR(clock)) { if (PTR_ERR(clock) == -EPROBE_DEFER) { while (--i >= 0) { - if (par->clks[i]) - clk_put(par->clks[i]); + clk_put(par->clks[i]); } kfree(par->clks); return -EPROBE_DEFER; -- 2.35.1