From: Helge Deller <deller@gmx.de>
To: linux-fbdev@vger.kernel.org, daniel.vetter@ffwll.ch,
dri-devel@lists.freedesktop.org, geert@linux-m68k.org
Subject: [PATCH v3 3/4] fbmem: Check virtual screen sizes in fb_set_var()
Date: Wed, 6 Jul 2022 17:02:52 +0200 [thread overview]
Message-ID: <20220706150253.2186-4-deller@gmx.de> (raw)
In-Reply-To: <20220706150253.2186-1-deller@gmx.de>
Verify that the fbdev or drm driver correctly adjusted the virtual
screen sizes. On failure report the failing driver and reject the screen
size change.
Signed-off-by: Helge Deller <deller@gmx.de>
Cc: stable@vger.kernel.org # v5.4+
---
drivers/video/fbdev/core/fbmem.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 160389365a36..612b54c23ac7 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -1016,6 +1016,17 @@ fb_set_var(struct fb_info *info, struct fb_var_screeninfo *var)
if (ret)
return ret;
+ /* verify that virtual resolution >= physical resolution */
+ if (var->xres_virtual < var->xres ||
+ var->yres_virtual < var->yres) {
+ pr_warn("WARNING: fbcon: Driver '%s' missed to adjust virtual"
+ " screen size (%dx%d vs. %dx%d)\n",
+ info->fix.id,
+ var->xres_virtual, var->yres_virtual,
+ var->xres, var->yres);
+ return -EINVAL;
+ }
+
if ((var->activate & FB_ACTIVATE_MASK) != FB_ACTIVATE_NOW)
return 0;
--
2.35.3
next prev parent reply other threads:[~2022-07-06 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 15:02 [PATCH v3 0/4] fbcon: Fixes for screen resolution changes Helge Deller
2022-07-06 15:02 ` [PATCH v3 1/4] fbcon: Disallow setting font bigger than screen size Helge Deller
2022-07-06 15:02 ` [PATCH v3 2/4] fbcon: Prevent that screen size is smaller than font size Helge Deller
2022-07-07 8:18 ` Geert Uytterhoeven
2022-07-06 15:02 ` Helge Deller [this message]
2022-07-07 8:20 ` [PATCH v3 3/4] fbmem: Check virtual screen sizes in fb_set_var() Geert Uytterhoeven
2022-07-06 15:02 ` [PATCH v3 4/4] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible() Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706150253.2186-4-deller@gmx.de \
--to=deller@gmx.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).