From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7279C433EF for ; Thu, 14 Jul 2022 12:05:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238670AbiGNMFs (ORCPT ); Thu, 14 Jul 2022 08:05:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237959AbiGNMFo (ORCPT ); Thu, 14 Jul 2022 08:05:44 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E4CF5C379; Thu, 14 Jul 2022 05:05:44 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 80DF65C010C; Thu, 14 Jul 2022 08:05:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 14 Jul 2022 08:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657800343; x=1657886743; bh=ByZfPRJBbk rVwwMD7jhiSx78ihc3R//dZAXdFGDSPi0=; b=NiNA4zuAhOprHEJDMsUbvxr9iA xY7+8+NbdC+5CGgreN5rKAVfg+rNUxCl4Ob8gsp807FeegUGIRv+aEwJXEqPXLuL GlYlwO7v3ZKEPu9fog/KeaxvVmZY5PxopvguP89AfdvLupzq5G31Mt93DOteYPvC YE+2h7B5Ftfm2COF0wl5f2mjm8q8oPIBO2QoILVEK87Ber/GfwSI9I/RLWrYaG0S 9CDqcOSjudEJWCgbiaIQbgE5s2jT6pSETeRJ8dS5ICM9mcomTYtnfW2JmzOJITMz LwJdo84E9HI1sf7FL0pJMTNE5ubApDcEw+5htUW/EA1QU/6xNhC/HX2XrvNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657800343; x=1657886743; bh=ByZfPRJBbkrVwwMD7jhiSx78ihc3 R//dZAXdFGDSPi0=; b=UZ9Lr+u79FHOmT5vHSfEpddfVavWK/JWWJZCh+8P0/DS bHm77HRqOxcbxWlf9xKAOQso/J0PN0i8+7Kjsx7JzbrZhksMKYUBVAKoYqpAzXFC TStDAYr+w/jKdXLRuXbt5mkhHa0Q1R6IVANTCmj5aZbP9T+ZcYi7NInBve5GWa7p ucn+jAfSEZRcLZyIiPSFRLROu+60Bq4vqHPM98UX9bUX8zKy844O9VjZYnorbM57 GpunVFQM4mULRtWzVuIFL3T+wMSVsu7I4EwszF/9U8+aXAZfU6CTNMp/KCasMv25 s3EUUKZArR4FVAAdvmyNL56tTfZIcIy8oKZk4y1+bA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejledggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Jul 2022 08:05:42 -0400 (EDT) Date: Thu, 14 Jul 2022 14:05:41 +0200 From: Maxime Ripard To: Geert Uytterhoeven Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Hans de Goede , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] drm/modes: parse_cmdline: Make mode->*specified handling more uniform Message-ID: <20220714120541.dpjl3dxptqvcit6b@houat> References: <3696bcbf95fa1ae98f452c7ea32072642b46caa7.1657788997.git.geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zqphagzjfcqkdkrb" Content-Disposition: inline In-Reply-To: <3696bcbf95fa1ae98f452c7ea32072642b46caa7.1657788997.git.geert@linux-m68k.org> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org --zqphagzjfcqkdkrb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 14, 2022 at 11:04:08AM +0200, Geert Uytterhoeven wrote: > The various mode->*specified flags are not handled in an uniform way: > some flags are set by the corresponding drm_mode_parse_cmdline_*() > function, some flags by the caller of the function, and some flags by > both. >=20 > Make this uniform by making this the responsibility of the various > parsing helpers, i.e. > - Move the setting of mode->specified from caller to callee, > - Drop the duplicate setting of mode->bpp_specified and > mode->refresh_specified from callers. >=20 > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Hans de Goede > Acked-by: Thomas Zimmermann Acked-by: Maxime Ripard Maxime --zqphagzjfcqkdkrb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYtAGlQAKCRDj7w1vZxhR xbYSAP4n8byE76xnaz+zJlmcuONil87f7RhgXKvX6yMYqCt6uwEA2sWGngLBw1vm nCeY8s9hiGX9FigyClThmd0pVfQYxQc= =uRN9 -----END PGP SIGNATURE----- --zqphagzjfcqkdkrb--