From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, deller@gmx.de, daniel@ffwll.ch,
sam@ravnborg.org, maxime@cerno.tech
Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 03/11] fbdev/vga16fb: Auto-generate module init/exit code
Date: Mon, 18 Jul 2022 09:23:14 +0200 [thread overview]
Message-ID: <20220718072322.8927-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20220718072322.8927-1-tzimmermann@suse.de>
Move vgag16fb's option parsing into the driver's probe function and
generate the rest of the module's init/exit functions from macros.
Keep the options code, although there are no options defined.
v2:
* no options are supported, remove the code (Javier)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/video/fbdev/vga16fb.c | 41 +----------------------------------
1 file changed, 1 insertion(+), 40 deletions(-)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 9e614c1db03d..3312b6a4e00d 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -1304,21 +1304,6 @@ static const struct fb_ops vga16fb_ops = {
.fb_imageblit = vga16fb_imageblit,
};
-#ifndef MODULE
-static int __init vga16fb_setup(char *options)
-{
- char *this_opt;
-
- if (!options || !*options)
- return 0;
-
- while ((this_opt = strsep(&options, ",")) != NULL) {
- if (!*this_opt) continue;
- }
- return 0;
-}
-#endif
-
static int vga16fb_probe(struct platform_device *dev)
{
struct screen_info *si;
@@ -1449,31 +1434,7 @@ static struct platform_driver vga16fb_driver = {
.id_table = vga16fb_driver_id_table,
};
-static int __init vga16fb_init(void)
-{
- int ret;
-#ifndef MODULE
- char *option = NULL;
-
- if (fb_get_options("vga16fb", &option))
- return -ENODEV;
-
- vga16fb_setup(option);
-#endif
-
- ret = platform_driver_register(&vga16fb_driver);
- if (ret)
- return ret;
-
- return 0;
-}
-
-static void __exit vga16fb_exit(void)
-{
- platform_driver_unregister(&vga16fb_driver);
-}
+module_platform_driver(vga16fb_driver);
MODULE_DESCRIPTION("Legacy VGA framebuffer device driver");
MODULE_LICENSE("GPL");
-module_init(vga16fb_init);
-module_exit(vga16fb_exit);
--
2.36.1
next prev parent reply other threads:[~2022-07-18 7:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 7:23 [PATCH v2 00/11] fbdev: Maintain device ownership with aperture helpers Thomas Zimmermann
2022-07-18 7:23 ` [PATCH v2 02/11] fbdev/vga16fb: Create EGA/VGA devices in sysfb code Thomas Zimmermann
2022-07-18 7:23 ` Thomas Zimmermann [this message]
2022-07-18 7:23 ` [PATCH v2 04/11] fbdev/core: Remove remove_conflicting_pci_framebuffers() Thomas Zimmermann
2022-07-18 7:23 ` [PATCH v2 05/11] fbdev: Convert drivers to aperture helpers Thomas Zimmermann
2022-07-18 9:57 ` kernel test robot
2022-07-18 7:23 ` [PATCH v2 06/11] fbdev: Remove conflicting devices on PCI bus Thomas Zimmermann
2022-07-21 14:17 ` Geert Uytterhoeven
2022-07-18 7:23 ` [PATCH v2 07/11] video/aperture: Disable and unregister sysfb devices via aperture helpers Thomas Zimmermann
2023-03-20 1:47 ` Samuel Čavoj
2023-03-20 9:46 ` Thomas Zimmermann
2023-03-20 10:13 ` Javier Martinez Canillas
2023-03-20 11:08 ` Samuel Čavoj
2023-03-20 12:12 ` Javier Martinez Canillas
2023-03-28 15:19 ` Samuel Čavoj
2023-04-04 11:36 ` Javier Martinez Canillas
2022-07-18 7:23 ` [PATCH v2 08/11] video: Provide constants for VGA I/O range Thomas Zimmermann
2022-07-18 7:23 ` [PATCH v2 09/11] video/aperture: Remove conflicting VGA devices, if any Thomas Zimmermann
2022-07-18 7:23 ` [PATCH v2 10/11] fbdev: Acquire framebuffer apertures for firmware devices Thomas Zimmermann
2022-07-18 7:23 ` [PATCH v2 11/11] fbdev: Remove conflict-handling code Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718072322.8927-4-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=maxime@cerno.tech \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).