linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Lucas Stankus" <lucas.p.stankus@gmail.com>,
	"Puranjay Mohan" <puranjay12@gmail.com>,
	"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
	"Alexandru Tachici" <alexandru.tachici@analog.com>,
	"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Kent Gustavsson" <kent@minoris.se>,
	"Tomislav Denis" <tomislav.denis@avl.com>,
	"Oleksij Rempel" <linux@rempel-privat.de>,
	kernel@pengutronix.de,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Ricardo Ribalda" <ribalda@kernel.org>,
	"Dragos Bogdan" <dragos.bogdan@analog.com>,
	"Jean-Baptiste Maneyrol" <jmaneyrol@invensense.com>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Stefan Popa" <stefan.popa@analog.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Stephan Gerhold" <stephan@gerhold.net>,
	"Mike Looijmans" <mike.looijmans@topic.nl>,
	"Joachim Eastwood" <manabian@gmail.com>,
	"Tomas Melin" <tomas.melin@vaisala.com>,
	"Sean Nyekjaer" <sean@geanix.com>,
	"Beniamin Bia" <beniamin.bia@analog.com>,
	"Patrick Vasseur" <patrick.vasseur@c-s.fr>,
	"Charles-Antoine Couret" <charles-antoine.couret@essensium.com>,
	"Vladimir Barinov" <vladimir.barinov@cogentembedded.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Philippe Reynes" <tremyfr@yahoo.fr>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Akinobu Mita" <akinobu.mita@gmail.com>,
	"Alexandru Lazar" <alazar@startmail.com>,
	"Oskar Andero" <oskar.andero@gmail.com>,
	"Mårten Lindahl" <martenli@axis.com>,
	"Bogdan Pricop" <bogdan.pricop@emutex.com>,
	"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
	"Matt Ranostay" <matt.ranostay@konsulko.com>,
	"Dan Murphy" <dmurphy@ti.com>,
	"Gregory Clement" <gregory.clement@bootlin.com>,
	"Phil Reid" <preid@electromag.com.au>,
	"Michael Welling" <mwelling@ieee.org>,
	"Robert Jones" <rjones@gateworks.com>,
	"Chris Coffey" <cmc@babblebit.net>,
	"Slawomir Stepien" <sst@poczta.fm>,
	"Sankar Velliangiri" <navin@linumiz.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 00/10] dt-bindings: iio: use spi-peripheral-props.yaml
Date: Wed, 3 Aug 2022 15:40:00 -0600	[thread overview]
Message-ID: <20220803214000.GB2639296-robh@kernel.org> (raw)
In-Reply-To: <20220801160410.GA6059@wunner.de>

On Mon, Aug 01, 2022 at 06:04:10PM +0200, Lukas Wunner wrote:
> On Mon, Aug 01, 2022 at 05:45:07PM +0200, Krzysztof Kozlowski wrote:
> > On 31/07/2022 00:46, Lukas Wunner wrote:
> > > On Wed, Jul 27, 2022 at 06:46:36PM +0200, Krzysztof Kozlowski wrote:
> > >>  78 files changed, 324 insertions(+), 249 deletions(-)
> > > 
> > > Pardon me for being dense, but what is the benefit of this series
> > > that justifies inflating the schema definitions by a total of 75 lines?
> > 
> > The commits were explaining rationale, so let me bring it here. The
> > benefits are:
> > This allows using all properties typical for SPI-connected devices, even
> > these which device bindings author did not tried yet.
> 
> How do you know these untested properties work with the devices to which
> you're adding them?

How do we know anything DT works? We don't without testing on h/w. 
That's not what the schemas provide.

The spi-peripheral-props.yaml reference is needed in order to allow 
controller specific timing properties and to prevent random 
other undocumented properties from being present. There is not another 
way to do both of those.

Do I wish we didn't have these controller specific timing parameters, 
yes! But that ship has sailed.

Rob

      parent reply	other threads:[~2022-08-03 21:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 16:46 [PATCH v2 00/10] dt-bindings: iio: use spi-peripheral-props.yaml Krzysztof Kozlowski
2022-07-27 16:46 ` [PATCH v2 01/10] dt-bindings: iio: adc: " Krzysztof Kozlowski
2022-07-27 16:56   ` Marcus Folkesson
2022-07-27 16:46 ` [PATCH v2 02/10] dt-bindings: iio: accel: " Krzysztof Kozlowski
2022-07-31 15:49   ` Jonathan Cameron
2022-08-03 21:29     ` Rob Herring
2022-08-04  7:27       ` Krzysztof Kozlowski
2022-08-06 17:31         ` Jonathan Cameron
2022-07-27 16:46 ` [PATCH v2 03/10] dt-bindings: iio: amplifiers: adi,ada4250: " Krzysztof Kozlowski
2022-07-27 16:46 ` [PATCH v2 04/10] dt-bindings: iio: dac: " Krzysztof Kozlowski
2022-07-30 22:43   ` Lukas Wunner
2022-07-27 16:46 ` [PATCH v2 05/10] dt-bindings: iio: frequency: adf4371: " Krzysztof Kozlowski
2022-07-27 16:46 ` [PATCH v2 06/10] dt-bindings: iio: health: ti,afe4403: " Krzysztof Kozlowski
2022-07-27 16:46 ` [PATCH v2 07/10] dt-bindings: iio: imu: " Krzysztof Kozlowski
2022-07-27 16:46 ` [PATCH v2 08/10] dt-bindings: iio: potentiometer: " Krzysztof Kozlowski
2022-07-27 16:46 ` [PATCH v2 09/10] dt-bindings: iio: samsung,sensorhub-rinato: " Krzysztof Kozlowski
2022-07-27 16:46 ` [PATCH v2 10/10] dt-bindings: iio: temperature: " Krzysztof Kozlowski
2022-07-30 22:46 ` [PATCH v2 00/10] dt-bindings: iio: " Lukas Wunner
2022-08-01 15:45   ` Krzysztof Kozlowski
2022-08-01 16:04     ` Lukas Wunner
2022-08-02  8:00       ` Krzysztof Kozlowski
2022-08-03 21:40       ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220803214000.GB2639296-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=akinobu.mita@gmail.com \
    --cc=alazar@startmail.com \
    --cc=alexandru.tachici@analog.com \
    --cc=angelo.compagnucci@gmail.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=beniamin.bia@analog.com \
    --cc=bogdan.pricop@emutex.com \
    --cc=charles-antoine.couret@essensium.com \
    --cc=cmc@babblebit.net \
    --cc=cosmin.tanislav@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=dragos.bogdan@analog.com \
    --cc=gregory.clement@bootlin.com \
    --cc=jacopo@jmondi.org \
    --cc=jic23@kernel.org \
    --cc=jmaneyrol@invensense.com \
    --cc=kent@minoris.se \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=lorenzo@kernel.org \
    --cc=lucas.p.stankus@gmail.com \
    --cc=lukas@wunner.de \
    --cc=manabian@gmail.com \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcus.folkesson@gmail.com \
    --cc=martenli@axis.com \
    --cc=matt.ranostay@konsulko.com \
    --cc=mike.looijmans@topic.nl \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwelling@ieee.org \
    --cc=navin@linumiz.com \
    --cc=oskar.andero@gmail.com \
    --cc=patrick.vasseur@c-s.fr \
    --cc=preid@electromag.com.au \
    --cc=puranjay12@gmail.com \
    --cc=ribalda@kernel.org \
    --cc=rjones@gateworks.com \
    --cc=sean@geanix.com \
    --cc=sst@poczta.fm \
    --cc=stefan.popa@analog.com \
    --cc=stephan@gerhold.net \
    --cc=tomas.melin@vaisala.com \
    --cc=tomislav.denis@avl.com \
    --cc=tremyfr@yahoo.fr \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).