From: Dan Carpenter <dan.carpenter@oracle.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Christopher Carbone <chris.m.carbone@gmail.com>,
sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Split multiple assignments to individual lines.
Date: Tue, 23 Aug 2022 11:41:34 +0300 [thread overview]
Message-ID: <20220823084133.GG2695@kadam> (raw)
In-Reply-To: <434d644b-2688-c3e8-814e-b9b2f2b86f85@gmail.com>
On Mon, Aug 22, 2022 at 08:05:57PM +0200, Philipp Hortmann wrote:
> I personally prefer more this:
>
> > + sm750_dev->fbinfo[1] = NULL;
> > + sm750_dev->fbinfo[0] = NULL;
>
> That gives a better overview.
>
Same for everywhere. Literals are clear than variables.
Bad: foo = bar;
Good: foo = -1;
Avoid pointless indirection.
regards,
dan carpenter
prev parent reply other threads:[~2022-08-23 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 15:41 [PATCH] Split multiple assignments to individual lines Christopher Carbone
2022-08-22 18:05 ` Philipp Hortmann
2022-08-23 8:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823084133.GG2695@kadam \
--to=dan.carpenter@oracle.com \
--cc=chris.m.carbone@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).