From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332EAECAAD1 for ; Thu, 1 Sep 2022 15:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233337AbiIAPCb (ORCPT ); Thu, 1 Sep 2022 11:02:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbiIAPC3 (ORCPT ); Thu, 1 Sep 2022 11:02:29 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4141D52807; Thu, 1 Sep 2022 08:02:25 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D76035C01D4; Thu, 1 Sep 2022 11:02:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 01 Sep 2022 11:02:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1662044542; x=1662130942; bh=OnCzvjXHRH y3N01m9+/V/6PmzsRMFO+pjDdDzmDLqh8=; b=bAWw0w7lmxKpxZhg0KSndm5IGa CjvSz8L9c46N144paZAd/ACxx4RaBaGy69H56TmCDTThTY+q17DurbG6LH1WBi57 LvkOeWBf/QCQRgOUz9/cs6xYu6irXXAAaG/YrqB7zup71MCijLAXRfF7zpyfYxen verVO4QKyY4ydq+zoWe0hlzunBuGUK03oYQzTkGYtMhhJfKQP8sWV1DqDfatv3d1 eTzGr+VA98WfhEYaa/CFpjW3riVnAFJNfhoDZlZSL6zOy7h460Kp8krb87wYEals /eI5AEU5q2y7i/KnTJuvRPp2gv0QGz0n7xjMAVaafbFqRxbbmzS8NjDbVkDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1662044542; x=1662130942; bh=OnCzvjXHRHy3N01m9+/V/6PmzsRM FO+pjDdDzmDLqh8=; b=jxvUFZvhqZPLAJFitpqPXFK02DNY6gEoVnbdqlzONrTx ZXlWjBv67U9rAioUyCZpqf8OBuYEeUrWrUBVGjtn5S2sYXlAGGwWOwY5IoKGi2ld rzIZ7TV/dCkMlNPBg1hToMEOaEp050WElhfHU4Stpk3fIACol/cjsfAHgXskminz E2eKBMyrTpqgupR7kVDXYnZwdBLfYDedW4vfZEWjSurlzx37DQ3XsLJcYDhOOvO5 3bioGzxfv7fTnLz9Gp7TRSZLoi+ZoUf/cBIlTS9XLfw2+K04pzcV0llfK74K/e1c 4+r/Bkaa7G1TYNOEx1ZVDwRky93ijtOQ6SirNK3qLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekkedgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeejgeeiveevvdfgffeftdevuefhheduveejieefgeejveeuhfetkeelgfev teefffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Sep 2022 11:02:20 -0400 (EDT) Date: Thu, 1 Sep 2022 17:02:16 +0200 From: Maxime Ripard To: =?utf-8?Q?Micha=C5=82?= Winiarski Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , David Gow , Javier Martinez Canillas , Maarten Lankhorst , Thomas Zimmermann , Jonathan Corbet , Helge Deller , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= Subject: Re: [PATCH] drm: Simplify testing on UML with kunit.py Message-ID: <20220901150216.gt4ozth6oz6cwgjt@houat> References: <20220901133621.353270-1-michal.winiarski@intel.com> <20220901140253.6ebvykv35kyc3v3w@houat> <20220901144909.6rihfj4mgklk3ddf@nostramo.hardline.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v37zbd2gmhxbbh3v" Content-Disposition: inline In-Reply-To: <20220901144909.6rihfj4mgklk3ddf@nostramo.hardline.pl> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org --v37zbd2gmhxbbh3v Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 01, 2022 at 04:49:09PM +0200, Micha=C5=82 Winiarski wrote: > On Thu, Sep 01, 2022 at 04:02:53PM +0200, Maxime Ripard wrote: > > Hi, > >=20 > > On Thu, Sep 01, 2022 at 03:36:21PM +0200, Micha=C5=82 Winiarski wrote: > > > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull= in > > > IOMEM and DMA emulation on UML. > > > Since --kconfig_add usage is no longer needed, remove it from > > > documentation. > > >=20 > > > Signed-off-by: Micha=C5=82 Winiarski > > > --- > > > Documentation/gpu/drm-internals.rst | 7 +------ > > > drivers/video/Kconfig | 4 ++++ > > > 2 files changed, 5 insertions(+), 6 deletions(-) > > >=20 > > > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/= drm-internals.rst > > > index 5fd20a306718..c264a9587d21 100644 > > > --- a/Documentation/gpu/drm-internals.rst > > > +++ b/Documentation/gpu/drm-internals.rst > > > @@ -228,16 +228,11 @@ follows: > > > =20 > > > .. code-block:: bash > > > =20 > > > - $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/dr= m/tests \ > > > - --kconfig_add CONFIG_VIRTIO_UML=3Dy \ > > > - --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=3Dy > > > + $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/dr= m/tests > > > =20 > > > .. note:: > > > The configuration included in ``.kunitconfig`` should be as generic= as > > > possible. > > > - ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not > > > - included in it because they are only required for User Mode Linux. > > > - > >=20 > > I'm all for removing that part of the documentation, but because > > 6fc3a8636a7b, in 6.0 should address this entirely? Why would we need > > that other symbol? >=20 > We don't. I wasn't aware that 6fc3a8636a7b exists and had this one in my = tree > prior to 6.0. > (well... technically we do need those other symbols and don't need VIRTIO= , but > since CONFIG_UML_PCI_OVER_VIRTIO pull in those two, it also works). > Since docs were not updated, I didn't see any conflicts when rebasing. >=20 > Sorry for the noise, please ignore this patch. I mean, the doc still isn't up to date, so please send that part of the patch :) Maxime --v37zbd2gmhxbbh3v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYxDJeAAKCRDj7w1vZxhR xfn6AP9az1d/tvykqX2O94leJJ+WaUANxEmlxQ4simD8YMJHDwEA3+Lorxpg5ULV d3Xg5NRITlDK7yxBCYTbbOdSjfgtggg= =jMVD -----END PGP SIGNATURE----- --v37zbd2gmhxbbh3v--