Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Yu Liao <liaoyu15@huawei.com>
To: <lee@kernel.org>, <deller@gmx.de>
Cc: <liwei391@huawei.com>, <linux-fbdev@vger.kernel.org>,
	<liaoyu15@huawei.com>
Subject: [PATCH] backlight: fix build error when CONFIG_ARCH_OMAP1_ANY=n
Date: Tue, 8 Nov 2022 19:38:35 +0800	[thread overview]
Message-ID: <20221108113835.4135655-1-liaoyu15@huawei.com> (raw)

If CONFIG_BACKLIGHT_OMAP1=y and CONFIG_ARCH_OMAP1_ANY=n, it leads a build
error:

	drivers/video/backlight/omap1_bl.o: In function `omapbl_probe':
	omap1_bl.c:(.text+0x198): undefined reference to `omap_cfg_reg'

Here is the link to the issue reported by kernel test bot:

https://lore.kernel.org/lkml/202211060819.fHDGmrB4-lkp@intel.com/

arch/arm/mach-omap1/mux.c where defines omap_cfg_reg() depends on
CONFIG_ARCH_OMAP1_ANY, so make CONFIG_BACKLIGHT_OMAP1 depends on
CONFIG_ARCH_OMAP1_ANY to fix it. ARCH_OMAP1_ANY depends on ARCH_OMAP1,
so the following logic is equivalent:

ARCH_OMAP1_ANY && (ARCH_OMAP1 || COMPILE_TEST) = ARCH_OMAP1_ANY

Fixes: 7036440eab3e ("ARM: omap1: enable multiplatform")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Yu Liao <liaoyu15@huawei.com>
---
 drivers/video/backlight/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 936ba1e4d35e..ff66cfebe45a 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -211,7 +211,7 @@ config BACKLIGHT_LOCOMO
 
 config BACKLIGHT_OMAP1
 	tristate "OMAP1 PWL-based LCD Backlight"
-	depends on ARCH_OMAP1 || COMPILE_TEST
+	depends on ARCH_OMAP1_ANY
 	default ARCH_OMAP1
 	help
 	  This driver controls the LCD backlight level and power for
-- 
2.25.1


             reply	other threads:[~2022-11-08 11:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 11:38 Yu Liao [this message]
2022-11-09  2:06 ` [PATCH] backlight: fix build error when CONFIG_ARCH_OMAP1_ANY=n Yu Liao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221108113835.4135655-1-liaoyu15@huawei.com \
    --to=liaoyu15@huawei.com \
    --cc=deller@gmx.de \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=liwei391@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox