* [PATCH linux-next] fbdev: use strscpy() to instead of strncpy()
@ 2022-12-28 1:44 yang.yang29
2022-12-28 7:58 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: yang.yang29 @ 2022-12-28 1:44 UTC (permalink / raw)
To: deller
Cc: javierm, tzimmermann, christophe.leroy, wsa+renesas, linux-fbdev,
dri-devel, linux-kernel, xu.panda, yang.yang29
From: Xu Panda <xu.panda@zte.com.cn>
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
---
drivers/video/fbdev/aty/atyfb_base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index 0ccf5d401ecb..851c1236fddb 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -3192,8 +3192,7 @@ static void aty_init_lcd(struct atyfb_par *par, u32 bios_base)
* which we print to the screen.
*/
id = *(u8 *)par->lcd_table;
- strncpy(model, (char *)par->lcd_table+1, 24);
- model[23] = 0;
+ strscpy(model, (char *)par->lcd_table+1, 24);
width = par->lcd_width = *(u16 *)(par->lcd_table+25);
height = par->lcd_height = *(u16 *)(par->lcd_table+27);
--
2.15.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] fbdev: use strscpy() to instead of strncpy()
2022-12-28 1:44 [PATCH linux-next] fbdev: use strscpy() to instead of strncpy() yang.yang29
@ 2022-12-28 7:58 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-12-28 7:58 UTC (permalink / raw)
To: yang.yang29
Cc: javierm, tzimmermann, christophe.leroy, wsa+renesas, linux-fbdev,
dri-devel, linux-kernel, xu.panda
On 12/28/22 02:44, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
> drivers/video/fbdev/aty/atyfb_base.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
applied.
Thanks!
Helge
>
> diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
> index 0ccf5d401ecb..851c1236fddb 100644
> --- a/drivers/video/fbdev/aty/atyfb_base.c
> +++ b/drivers/video/fbdev/aty/atyfb_base.c
> @@ -3192,8 +3192,7 @@ static void aty_init_lcd(struct atyfb_par *par, u32 bios_base)
> * which we print to the screen.
> */
> id = *(u8 *)par->lcd_table;
> - strncpy(model, (char *)par->lcd_table+1, 24);
> - model[23] = 0;
> + strscpy(model, (char *)par->lcd_table+1, 24);
>
> width = par->lcd_width = *(u16 *)(par->lcd_table+25);
> height = par->lcd_height = *(u16 *)(par->lcd_table+27);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-28 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-28 1:44 [PATCH linux-next] fbdev: use strscpy() to instead of strncpy() yang.yang29
2022-12-28 7:58 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).