From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 05/13] backlight: hp680_bl: Convert to platform remove callback returning void
Date: Thu, 16 Mar 2023 13:49:14 +0000 [thread overview]
Message-ID: <20230316134914.GT9667@google.com> (raw)
In-Reply-To: <20230308073945.2336302-6-u.kleine-koenig@pengutronix.de>
On Wed, 08 Mar 2023, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/video/backlight/hp680_bl.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-03-16 13:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 7:39 [PATCH 00/13] backlight: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-08 7:39 ` [PATCH 01/13] backlight: aat2870_bl: " Uwe Kleine-König
2023-03-16 13:47 ` Lee Jones
2023-03-08 7:39 ` [PATCH 02/13] backlight: adp5520_bl: " Uwe Kleine-König
2023-03-08 7:45 ` Hennerich, Michael
2023-03-16 13:47 ` Lee Jones
2023-03-08 7:39 ` [PATCH 03/13] backlight: cr_bllcd: " Uwe Kleine-König
2023-03-16 13:48 ` Lee Jones
2023-03-08 7:39 ` [PATCH 04/13] backlight: da9052_bl: " Uwe Kleine-König
2023-03-08 9:23 ` DLG Adam Ward
2023-03-16 13:48 ` Lee Jones
2023-03-08 7:39 ` [PATCH 05/13] backlight: hp680_bl: " Uwe Kleine-König
2023-03-16 13:49 ` Lee Jones [this message]
2023-03-08 7:39 ` [PATCH 06/13] backlight: led_bl: " Uwe Kleine-König
2023-03-16 13:49 ` Lee Jones
2023-03-08 7:39 ` [PATCH 07/13] backlight: lm3533_bl: " Uwe Kleine-König
2023-03-16 13:50 ` Lee Jones
2023-03-08 7:39 ` [PATCH 08/13] backlight: lp8788_bl: " Uwe Kleine-König
2023-03-16 13:50 ` Lee Jones
2023-03-08 7:39 ` [PATCH 09/13] backlight: mt6370-backlight: " Uwe Kleine-König
2023-03-16 13:50 ` Lee Jones
2023-03-08 7:39 ` [PATCH 10/13] backlight: pwm_bl: " Uwe Kleine-König
2023-03-16 13:51 ` Lee Jones
2023-03-08 7:39 ` [PATCH 11/13] backlight: qcom-wled: " Uwe Kleine-König
2023-03-16 13:51 ` Lee Jones
2023-03-08 7:39 ` [PATCH 12/13] backlight: rt4831-backlight: " Uwe Kleine-König
2023-03-16 13:51 ` Lee Jones
2023-03-08 7:39 ` [PATCH 13/13] backlight: sky81452-backlight: " Uwe Kleine-König
2023-03-16 13:52 ` Lee Jones
2023-03-08 12:04 ` [PATCH 00/13] backlight: " Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316134914.GT9667@google.com \
--to=lee@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).