From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D76C7EE24 for ; Tue, 6 Jun 2023 08:18:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235936AbjFFISE (ORCPT ); Tue, 6 Jun 2023 04:18:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235891AbjFFISB (ORCPT ); Tue, 6 Jun 2023 04:18:01 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86CED11B for ; Tue, 6 Jun 2023 01:17:58 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-30b023b0068so4158589f8f.0 for ; Tue, 06 Jun 2023 01:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686039477; x=1688631477; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cSpRJEPqPVqhoSAFcxKLrdKHmoUN6BNCQfphia1KCDc=; b=Mpc+MQI1MneytiHZlBGaFATUvZ2D7UN1Dd8CesjFWTyP49rsZyjD8jnaaR2NWOdDYa ipHtgV6xxEWHjDPiqr2vBbciA3+K0fJJ7K1xXjC7+LEEVocVIIUJi94ZOqHXXoTSgzrG mxeqOJel8vvWWKD6+i5csIDgelH/jVykDsjgcbudQFFfZ7CAf/f920BH4IoknBSQ53hq hYHtrf7a3GRFH2D0iZ/WCyHV6yJHs8gv/lj4ehZmceJwESSII8vcD1ixg8gZhNul0KKy 68n7AIGGrWW/DnIWzedWWopU6PP+9paqpLoKdw2Qdi7FG3cHOBeBfAZJZ1pCvU6/Hl6d tABg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686039477; x=1688631477; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cSpRJEPqPVqhoSAFcxKLrdKHmoUN6BNCQfphia1KCDc=; b=A27T1li8gQVMoekVr90Dbm6pqesJLDQWEHrRsaNOsN0BziQ4NZKeq9EQ0dnBYYkFWI 58cQK+gDrb8NCKEZ//oLynuqr+1fwL06RqztE5BCWSW3RI2zbkrxC4sobt1BmeUcLzO1 nQTw2gg0aDu06ken+UpmxaPmuy/af6e+y3o92tiBZrQbESSbaTtQWe+R8M8R9AXs/m5j 0ui7mf5Zd8KmGfabpWRxi8WhFWMvo1lSw4V/jas/9yy3gpYV/q95tJeBd/jpKi+YwM9W HBZj8yIJ+LOY1sf7ABVSP1Bj7cpTJNnQBzCVFyYJ9nsNpQTeGh5v6Nar9svsuD/Xxvko ZYbw== X-Gm-Message-State: AC+VfDx8CL1tbeMLxGhfEKiYsfkjpLc7HdswpZTI+xlqqV3YonTIowAL 2Kh44bREhuRKkA/JI02yOWhJBg== X-Google-Smtp-Source: ACHHUZ7IXBOZigfcocE6Us3xOMsMk/mjRsDKCskt5eDsJGA9seSXJvit+vkIb+CpvRFtcFD997m2jg== X-Received: by 2002:adf:e446:0:b0:2fe:e455:666c with SMTP id t6-20020adfe446000000b002fee455666cmr8811328wrm.33.1686039476965; Tue, 06 Jun 2023 01:17:56 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id c1-20020a5d4cc1000000b002fda1b12a0bsm11907760wrt.2.2023.06.06.01.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 01:17:56 -0700 (PDT) Date: Tue, 6 Jun 2023 09:17:54 +0100 From: Daniel Thompson To: Andy Shevchenko Cc: Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Bartosz Golaszewski , Lee Jones , Jingoo Han , Helge Deller Subject: Re: [PATCH v1 1/1] backlight: hx8357: Convert to agnostic GPIO API Message-ID: <20230606081754.GA218497@aspen.lan> References: <20230317185230.46189-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, Jun 05, 2023 at 07:07:24PM +0300, Andy Shevchenko wrote: > On Mon, Mar 20, 2023 at 01:54:26PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 17, 2023 at 09:53:40PM +0100, Linus Walleij wrote: > > > On Fri, Mar 17, 2023 at 7:51 PM Andy Shevchenko > > > wrote: > > > > > > > The of_gpio.h is going to be removed. In preparation of that convert > > > > the driver to the agnostic API. > > > > > > > > Signed-off-by: Andy Shevchenko > > > > > > Thanks for fixing this Andy! > > > > > > > -#if !IS_ENABLED(CONFIG_LCD_HX8357) > > > > +#if IS_ENABLED(CONFIG_LCD_HX8357) > > > > /* > > > > * Himax LCD controllers used incorrectly named > > > > * "gpios-reset" property and also specified wrong > > > > @@ -452,7 +452,7 @@ static struct gpio_desc *of_find_gpio_rename(struct device_node *np, > > > > */ > > > > const char *compatible; > > > > } gpios[] = { > > > > -#if !IS_ENABLED(CONFIG_LCD_HX8357) > > > > +#if IS_ENABLED(CONFIG_LCD_HX8357) > > > > /* Himax LCD controllers used "gpios-reset" */ > > > > { "reset", "gpios-reset", "himax,hx8357" }, > > > > { "reset", "gpios-reset", "himax,hx8369" }, > > > > > > Eh what happened here .. it's even intuitively wrong. > > > > I believe it had to be something like > > > > #if 0 && IS_ENABLED() > > > > to show that this change is for the future. > > Currently it does something unneeded for the kernels with that option off. > > > > > I would add > > > Fixes: fbbbcd177a27 ("gpiolib: of: add quirk for locating reset lines > > > with legacy bindings") > > > > I'm not sure. But it's fine, I can add it. Just want to double confirm > > you really want this Fixes tag. > > > > > It wasn't used until now it seems so not a regression and no > > > need for a separate patch. > > > > Exactly why I'm not sure about the tag :-) > > > > > Other than that it looks correct. > > > Reviewed-by: Linus Walleij > > > > Thank you! > > Lee, is anything I can do here to move this forward? Backlight code looks OK to me (although I might regard the Fixes: discussion as unresolved)there is an unresolved): Reviewed-by: Daniel Thompson Daniel.