From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org,
deller@gmx.de, geert+renesas@glider.be, lee@kernel.org,
daniel.thompson@linaro.org, jingoohan1@gmail.com,
dan.carpenter@linaro.org, michael.j.ruhl@intel.com
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-sh@vger.kernel.org, linux-omap@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 26/38] fbdev/sh7760fb: Output messages with fb_dbg()
Date: Mon, 12 Jun 2023 16:08:04 +0200 [thread overview]
Message-ID: <20230612141352.29939-27-tzimmermann@suse.de> (raw)
In-Reply-To: <20230612141352.29939-1-tzimmermann@suse.de>
Fix cases were output helpers are called with struct fb_info.dev.
Use fb_dbg() instead. Prepares fbdev for making struct fb_info.dev
optional.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/fbdev/sh7760fb.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/video/fbdev/sh7760fb.c b/drivers/video/fbdev/sh7760fb.c
index a2946f06d579e..65e2c71cf5b51 100644
--- a/drivers/video/fbdev/sh7760fb.c
+++ b/drivers/video/fbdev/sh7760fb.c
@@ -207,7 +207,7 @@ static int sh7760fb_set_par(struct fb_info *info)
/* rotate only works with xres <= 320 */
if (par->rot && (vm->xres > 320)) {
- dev_dbg(info->dev, "rotation disabled due to display size\n");
+ fb_dbg(info, "rotation disabled due to display size\n");
par->rot = 0;
}
@@ -226,7 +226,7 @@ static int sh7760fb_set_par(struct fb_info *info)
if (ret)
return ret;
- dev_dbg(info->dev, "%dx%d %dbpp %s (orientation %s)\n", hdcn,
+ fb_dbg(info, "%dx%d %dbpp %s (orientation %s)\n", hdcn,
vdln, bpp, gray ? "grayscale" : "color",
par->rot ? "rotated" : "normal");
@@ -306,7 +306,7 @@ static int sh7760fb_set_par(struct fb_info *info)
if (((ldmtr & 0x003f) >= LDMTR_DSTN_MONO_8) &&
((ldmtr & 0x003f) <= LDMTR_DSTN_COLOR_16)) {
- dev_dbg(info->dev, " ***** DSTN untested! *****\n");
+ fb_dbg(info, " ***** DSTN untested! *****\n");
dstn_off = stride;
if (par->rot)
@@ -326,17 +326,17 @@ static int sh7760fb_set_par(struct fb_info *info)
sh7760fb_blank(FB_BLANK_UNBLANK, info); /* panel on! */
- dev_dbg(info->dev, "hdcn : %6d htcn : %6d\n", hdcn, htcn);
- dev_dbg(info->dev, "hsynw : %6d hsynp : %6d\n", hsynw, hsynp);
- dev_dbg(info->dev, "vdln : %6d vtln : %6d\n", vdln, vtln);
- dev_dbg(info->dev, "vsynw : %6d vsynp : %6d\n", vsynw, vsynp);
- dev_dbg(info->dev, "clksrc: %6d clkdiv: %6d\n",
+ fb_dbg(info, "hdcn : %6d htcn : %6d\n", hdcn, htcn);
+ fb_dbg(info, "hsynw : %6d hsynp : %6d\n", hsynw, hsynp);
+ fb_dbg(info, "vdln : %6d vtln : %6d\n", vdln, vtln);
+ fb_dbg(info, "vsynw : %6d vsynp : %6d\n", vsynw, vsynp);
+ fb_dbg(info, "clksrc: %6d clkdiv: %6d\n",
(par->pd->ldickr >> 12) & 3, par->pd->ldickr & 0x1f);
- dev_dbg(info->dev, "ldpmmr: 0x%04x ldpspr: 0x%04x\n", par->pd->ldpmmr,
+ fb_dbg(info, "ldpmmr: 0x%04x ldpspr: 0x%04x\n", par->pd->ldpmmr,
par->pd->ldpspr);
- dev_dbg(info->dev, "ldmtr : 0x%04x lddfr : 0x%04x\n", ldmtr, lddfr);
- dev_dbg(info->dev, "ldlaor: %ld\n", stride);
- dev_dbg(info->dev, "ldsaru: 0x%08lx ldsarl: 0x%08lx\n", sbase, ldsarl);
+ fb_dbg(info, "ldmtr : 0x%04x lddfr : 0x%04x\n", ldmtr, lddfr);
+ fb_dbg(info, "ldlaor: %ld\n", stride);
+ fb_dbg(info, "ldsaru: 0x%08lx ldsarl: 0x%08lx\n", sbase, ldsarl);
return 0;
}
@@ -401,7 +401,7 @@ static int sh7760fb_alloc_mem(struct fb_info *info)
} else if (bpp > 8)
vram *= 2;
if ((vram < 1) || (vram > 1024 * 2048)) {
- dev_dbg(info->dev, "too much VRAM required. Check settings\n");
+ fb_dbg(info, "too much VRAM required. Check settings\n");
return -ENODEV;
}
--
2.41.0
next prev parent reply other threads:[~2023-06-12 14:14 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 14:07 [PATCH v2 00/38] fbdev: Make userspace interfaces optional Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device Thomas Zimmermann
2023-06-12 15:00 ` Dan Carpenter
2023-06-12 15:17 ` Ruhl, Michael J
2023-06-13 7:31 ` Thomas Zimmermann
2023-06-13 10:37 ` Daniel Thompson
2023-06-13 10:47 ` Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 02/38] backlight/bd6107: Rename struct bd6107_platform_data.fbdev to 'dev' Thomas Zimmermann
2023-06-13 10:38 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 03/38] backlight/gpio_backlight: Compare against struct fb_info.device Thomas Zimmermann
2023-06-13 10:38 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 04/38] backlight/gpio_backlight: Rename field 'fbdev' to 'dev' Thomas Zimmermann
2023-06-13 10:39 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 05/38] backlight/lv5207lp: Compare against struct fb_info.device Thomas Zimmermann
2023-06-13 10:39 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 06/38] backlight/lv5207lp: Rename struct lv5207lp_platform_data.fbdev to 'dev' Thomas Zimmermann
2023-06-13 10:40 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 07/38] fbdev/atyfb: Reorder backlight and framebuffer init/cleanup Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 08/38] fbdev/atyfb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 09/38] fbdev/aty128fb: Reorder backlight and framebuffer init/cleanup Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 10/38] fbdev/aty128fb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 11/38] fbdev/broadsheetfb: Call device_remove_file() with hardware device Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 12/38] fbdev/ep93xx-fb: Alloc DMA memory from " Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 13/38] fbdev/ep93xx-fb: Output messages with fb_info() and fb_err() Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 14/38] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 15/38] fbdev/fsl-diu-fb: Output messages with fb_*() helpers Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 16/38] fbdev/mb862xxfb: Output messages with fb_dbg() Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 17/38] fbdev/metronomefb: Use hardware device for dev_err() Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 18/38] fbdev/nvidiafb: Reorder backlight and framebuffer init/cleanup Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 19/38] fbdev/nvidiafb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 20/38] fbdev/pxa168fb: Do not assign to struct fb_info.dev Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 21/38] fbdev/radeonfb: Reorder backlight and framebuffer cleanup Thomas Zimmermann
2023-06-12 15:51 ` Sam Ravnborg
2023-06-12 14:08 ` [PATCH v2 22/38] fbdev/radeonfb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 23/38] fbdev/rivafb: Reorder backlight and framebuffer init/cleanup Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 24/38] fbdev/rivafb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 25/38] fbdev/sh7760fb: Use fb_dbg() in sh7760fb_get_color_info() Thomas Zimmermann
2023-06-12 14:08 ` Thomas Zimmermann [this message]
2023-06-12 14:08 ` [PATCH v2 27/38] fbdev/sh7760fb: Alloc DMA memory from hardware device Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 28/38] fbdev/sh7760fb: Use hardware device with dev_() output during probe Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 29/38] fbdev/sm501fb: Output message with fb_err() Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 30/38] fbdev/smscufx: Detect registered fb_info from refcount Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 31/38] fbdev/tdfxfb: Set i2c adapter parent to hardware device Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 32/38] fbdev/core: Pass Linux device to pm_vt_switch_*() functions Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 33/38] fbdev/core: Move framebuffer and backlight helpers into separate files Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 34/38] fbdev/core: Add fb_device_{create,destroy}() Thomas Zimmermann
2023-06-12 15:43 ` Sam Ravnborg
2023-06-12 14:08 ` [PATCH v2 35/38] fbdev/core: Move procfs code to separate file Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 36/38] fbdev/core: Move file-I/O code into " Thomas Zimmermann
2023-06-13 9:17 ` Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 37/38] fbdev/core: Rework fb init code Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 38/38] fbdev: Make support for userspace interfaces configurable Thomas Zimmermann
2023-06-13 10:43 ` Daniel Thompson
2023-06-12 15:56 ` [PATCH v2 00/38] fbdev: Make userspace interfaces optional Sam Ravnborg
2023-06-12 16:04 ` Javier Martinez Canillas
2023-06-13 10:41 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612141352.29939-27-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=dan.carpenter@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=javierm@redhat.com \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=michael.j.ruhl@intel.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).