From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 098ECC88CB4 for ; Mon, 12 Jun 2023 15:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238104AbjFLPoC (ORCPT ); Mon, 12 Jun 2023 11:44:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236367AbjFLPoA (ORCPT ); Mon, 12 Jun 2023 11:44:00 -0400 Received: from mailrelay3-1.pub.mailoutpod2-cph3.one.com (mailrelay3-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:402::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B63410CC for ; Mon, 12 Jun 2023 08:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=7bu+0WMycvl+xw/+UyWKXzBeoyi+ITWwP8OmM2m6w3U=; b=J+MAAjazh0cqG8FTxXFAYorKfEJAfsolz5nI559Jg1dYWl+zBGxsqkJ6L6BZ/ycEKGG0o5rYcqZCD kcppxqP96zS8pZRaW0AlxvZQddFQJ4FGG8xh7nLabP5jmbEiTmFPIxHZwE66kmSW9gc21kidZ3Sw6Q kSVUE8Jr9ytkg1ujf3zUjU3RDlwieTz5o2Yaq49RAUoHl1oR4/a72L8kbTgORoVdZxXVv+FHfJyCyU HBI5Dd92Attjse05uyKed0VvezEULHVIIhucSdj9Ses6OcByYncWv07UpbFe13TuZlfWCmJSGiQHmp Cu6rXjFgT0n7g5Qrp36lNE7Xhnc7BgQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=7bu+0WMycvl+xw/+UyWKXzBeoyi+ITWwP8OmM2m6w3U=; b=IC1PPDdgBDKI7zq8IJwwQGlbYUO3D4efEtYXAJFdx3LdaekNytlsyGPtFvhCi4WXxtdmi0mW6gEQ9 tHIWDuxDw== X-HalOne-ID: ef9b6055-0937-11ee-91ee-b90637070a9d Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay3 (Halon) with ESMTPSA id ef9b6055-0937-11ee-91ee-b90637070a9d; Mon, 12 Jun 2023 15:43:56 +0000 (UTC) Date: Mon, 12 Jun 2023 17:43:54 +0200 From: Sam Ravnborg To: Thomas Zimmermann Cc: daniel@ffwll.ch, javierm@redhat.com, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 34/38] fbdev/core: Add fb_device_{create,destroy}() Message-ID: <20230612154354.GA1243864@ravnborg.org> References: <20230612141352.29939-1-tzimmermann@suse.de> <20230612141352.29939-35-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612141352.29939-35-tzimmermann@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, Jun 12, 2023 at 04:08:12PM +0200, Thomas Zimmermann wrote: > Move the logic to create and destroy fbdev devices into the new > helpers fb_device_create() and fb_device_destroy(). > > There was a call to fb_cleanup_device() in do_unregister_framebuffer() > that was too late. The device had already been removed at this point. > Move the call into fb_device_destroy(). > > Declare the helpers in the new internal header file fb_internal.h, as > they are only used within the fbdev core module. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg