* [PATCH AUTOSEL 4.14 5/6] fbdev: imsttfb: Release framebuffer and dealloc cmap on error path [not found] <20230615114016.649846-1-sashal@kernel.org> @ 2023-06-15 11:40 ` Sasha Levin 2023-06-16 19:36 ` Pavel Machek 0 siblings, 1 reply; 2+ messages in thread From: Sasha Levin @ 2023-06-15 11:40 UTC (permalink / raw) To: linux-kernel, stable Cc: Helge Deller, Sasha Levin, javierm, tzimmermann, zyytlz.wz, linux-fbdev, dri-devel From: Helge Deller <deller@gmx.de> [ Upstream commit 5cf9a090a39c97f4506b7b53739d469b1c05a7e9 ] Add missing cleanups in error path. Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/video/fbdev/imsttfb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c index ecdcf358ad5ea..6589d5f0a5a40 100644 --- a/drivers/video/fbdev/imsttfb.c +++ b/drivers/video/fbdev/imsttfb.c @@ -1452,9 +1452,13 @@ static void init_imstt(struct fb_info *info) FBINFO_HWACCEL_FILLRECT | FBINFO_HWACCEL_YPAN; - fb_alloc_cmap(&info->cmap, 0, 0); + if (fb_alloc_cmap(&info->cmap, 0, 0)) { + framebuffer_release(info); + return -ENODEV; + } if (register_framebuffer(info) < 0) { + fb_dealloc_cmap(&info->cmap); framebuffer_release(info); return; } -- 2.39.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH AUTOSEL 4.14 5/6] fbdev: imsttfb: Release framebuffer and dealloc cmap on error path 2023-06-15 11:40 ` [PATCH AUTOSEL 4.14 5/6] fbdev: imsttfb: Release framebuffer and dealloc cmap on error path Sasha Levin @ 2023-06-16 19:36 ` Pavel Machek 0 siblings, 0 replies; 2+ messages in thread From: Pavel Machek @ 2023-06-16 19:36 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Helge Deller, javierm, tzimmermann, zyytlz.wz, linux-fbdev, dri-devel [-- Attachment #1: Type: text/plain, Size: 964 bytes --] Hi! > From: Helge Deller <deller@gmx.de> > > [ Upstream commit 5cf9a090a39c97f4506b7b53739d469b1c05a7e9 ] > > Add missing cleanups in error path. If we insist this is important enough for -stable, it will need tweaking. The function returns void, so we can't return a value. Best regards, Pavel > +++ b/drivers/video/fbdev/imsttfb.c > @@ -1452,9 +1452,13 @@ static void init_imstt(struct fb_info *info) > FBINFO_HWACCEL_FILLRECT | > FBINFO_HWACCEL_YPAN; > > - fb_alloc_cmap(&info->cmap, 0, 0); > + if (fb_alloc_cmap(&info->cmap, 0, 0)) { > + framebuffer_release(info); > + return -ENODEV; > + } > > if (register_framebuffer(info) < 0) { > + fb_dealloc_cmap(&info->cmap); > framebuffer_release(info); > return; > } -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-16 19:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230615114016.649846-1-sashal@kernel.org>
2023-06-15 11:40 ` [PATCH AUTOSEL 4.14 5/6] fbdev: imsttfb: Release framebuffer and dealloc cmap on error path Sasha Levin
2023-06-16 19:36 ` Pavel Machek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).