From: Rob Herring <robh@kernel.org>
To: Alexandru Ardelean <alex@shruggie.ro>
Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, lee@kernel.org,
daniel.thompson@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
deller@gmx.de, Yannick Fertre <yannick.fertre@foss.st.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: document new property default-brightness-level
Date: Wed, 21 Jun 2023 20:13:03 -0600 [thread overview]
Message-ID: <20230622021303.GA68330-robh@kernel.org> (raw)
In-Reply-To: <20230621215457.11297-1-alex@shruggie.ro>
On Thu, Jun 22, 2023 at 12:54:56AM +0300, Alexandru Ardelean wrote:
> From: Yannick Fertre <yannick.fertre@foss.st.com>
>
> Add documentation for new default-brightness-level property.
Why?
>
> Signed-off-by: Yannick Fertre <yannick.fertre@foss.st.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> ---
>
> Link to original patch:
> https://github.com/STMicroelectronics/linux/commit/c4067d7bd883c6fa14ffd49892c4ce663cdafe98
>
> Changelog v1 -> v2:
> * https://lore.kernel.org/dri-devel/20230519200520.10657-2-alex@shruggie.ro/
> * removed 'brightness-levels' reference
> * updated doc-text for 'default-brightness-level'
> * updated doc-text for 'default-on'
> * added 'minimum' & 'maximum' to 'default-brightness-level' property
> * removed 'Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>' as
> requested
> * patch is first in series of 2 patches (was second patch)
>
> .../bindings/leds/backlight/gpio-backlight.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> index 584030b6b0b9..2da6552a207c 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> @@ -20,9 +20,21 @@ properties:
> maxItems: 1
>
> default-on:
> - description: enable the backlight at boot.
> + description:
> + The default power state of the backlight at boot.
> type: boolean
>
> + default-brightness-level:
> + description:
> + The default brightness level on device init. The value can be 0 or 1.
> + If omitted, the value is 1. In the context of the "gpio-backlight" driver
> + the effect of this setting will be that the backlight is on/off.
> + The difference between this setting and "default-on" is that this handles
> + brightness, while "default-on" handles the power setting of the device.
What power setting? You only have 1 GPIO to control here which is 2
states. I fail to see why you need 6 possible states with all the
combinations of 2 properties.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 1
> +
> required:
> - compatible
> - gpios
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-06-22 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 21:54 [PATCH v2 1/2] dt-bindings: backlight: document new property default-brightness-level Alexandru Ardelean
2023-06-21 21:54 ` [PATCH v2 2/2] backlight: gpio_backlight: add " Alexandru Ardelean
2023-06-22 2:13 ` Rob Herring [this message]
2023-06-23 7:19 ` [PATCH v2 1/2] dt-bindings: backlight: document " Alexandru Ardelean
2023-06-23 11:32 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622021303.GA68330-robh@kernel.org \
--to=robh@kernel.org \
--cc=alex@shruggie.ro \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=yannick.fertre@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).