From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E53EB64D8 for ; Thu, 22 Jun 2023 15:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231384AbjFVPP4 (ORCPT ); Thu, 22 Jun 2023 11:15:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbjFVPPz (ORCPT ); Thu, 22 Jun 2023 11:15:55 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F794C2; Thu, 22 Jun 2023 08:15:54 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1025C905; Thu, 22 Jun 2023 17:15:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687446916; bh=syM2lf6xc0TcjGpjcQcGu7POjghphMWF206glBGE4HU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pdFBVFslugx/27dksYElGUWjRn6H00aKtQdKs87vIYeqSRfRzHxWkU4IX5nnICUho 4u6pvMREeC45QsobW/X5ZDrSQf0slqkbDxCLDKKlAZuF0NbwXS2tPxy0/p1WaM74Yy NCIeNLVZP5myvbSZPEU/goKxFBYCekAfl5PUUWR4= Date: Thu, 22 Jun 2023 18:15:50 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] fbdev: sh_mobile_lcdcfb: Fix ARGB32 overlay format typo Message-ID: <20230622151550.GB950@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:28:48AM +0200, Geert Uytterhoeven wrote: > When configurating a CHn Source Image Format Register (LDBBSIFR), one > should use the corresponding LDBBSIFR_RPKF_* definition for overlay > planes, not the DDFR_PKF_* definition for the primary plane. > > Fortunately both definitions resolve to the same value, so this bug did > not cause any harm. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index 093f035d12463a80..0adb2ba965e7120d 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -824,7 +824,7 @@ static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay *ovl) > format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24; > break; > case V4L2_PIX_FMT_BGR32: > - format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32; > + format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; Reviewed-by: Laurent Pinchart > break; > case V4L2_PIX_FMT_NV12: > case V4L2_PIX_FMT_NV21: -- Regards, Laurent Pinchart