* [PATCH] fbdev: sh_mobile_lcdcfb: Fix ARGB32 overlay format typo
@ 2023-06-22 9:28 Geert Uytterhoeven
2023-06-22 15:15 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-06-22 9:28 UTC (permalink / raw)
To: Helge Deller, Laurent Pinchart
Cc: linux-fbdev, dri-devel, linux-renesas-soc, Geert Uytterhoeven
When configurating a CHn Source Image Format Register (LDBBSIFR), one
should use the corresponding LDBBSIFR_RPKF_* definition for overlay
planes, not the DDFR_PKF_* definition for the primary plane.
Fortunately both definitions resolve to the same value, so this bug did
not cause any harm.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
index 093f035d12463a80..0adb2ba965e7120d 100644
--- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
+++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c
@@ -824,7 +824,7 @@ static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay *ovl)
format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24;
break;
case V4L2_PIX_FMT_BGR32:
- format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32;
+ format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32;
break;
case V4L2_PIX_FMT_NV12:
case V4L2_PIX_FMT_NV21:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: sh_mobile_lcdcfb: Fix ARGB32 overlay format typo
2023-06-22 9:28 [PATCH] fbdev: sh_mobile_lcdcfb: Fix ARGB32 overlay format typo Geert Uytterhoeven
@ 2023-06-22 15:15 ` Laurent Pinchart
2023-06-22 17:39 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2023-06-22 15:15 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Helge Deller, linux-fbdev, dri-devel, linux-renesas-soc
Hi Geert,
Thank you for the patch.
On Thu, Jun 22, 2023 at 11:28:48AM +0200, Geert Uytterhoeven wrote:
> When configurating a CHn Source Image Format Register (LDBBSIFR), one
> should use the corresponding LDBBSIFR_RPKF_* definition for overlay
> planes, not the DDFR_PKF_* definition for the primary plane.
>
> Fortunately both definitions resolve to the same value, so this bug did
> not cause any harm.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
> index 093f035d12463a80..0adb2ba965e7120d 100644
> --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
> +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c
> @@ -824,7 +824,7 @@ static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay *ovl)
> format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24;
> break;
> case V4L2_PIX_FMT_BGR32:
> - format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32;
> + format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32;
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> break;
> case V4L2_PIX_FMT_NV12:
> case V4L2_PIX_FMT_NV21:
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: sh_mobile_lcdcfb: Fix ARGB32 overlay format typo
2023-06-22 15:15 ` Laurent Pinchart
@ 2023-06-22 17:39 ` Helge Deller
0 siblings, 0 replies; 3+ messages in thread
From: Helge Deller @ 2023-06-22 17:39 UTC (permalink / raw)
To: Laurent Pinchart, Geert Uytterhoeven
Cc: linux-fbdev, dri-devel, linux-renesas-soc
On 6/22/23 17:15, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Thu, Jun 22, 2023 at 11:28:48AM +0200, Geert Uytterhoeven wrote:
>> When configurating a CHn Source Image Format Register (LDBBSIFR), one
>> should use the corresponding LDBBSIFR_RPKF_* definition for overlay
>> planes, not the DDFR_PKF_* definition for the primary plane.
>>
>> Fortunately both definitions resolve to the same value, so this bug did
>> not cause any harm.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-22 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-22 9:28 [PATCH] fbdev: sh_mobile_lcdcfb: Fix ARGB32 overlay format typo Geert Uytterhoeven
2023-06-22 15:15 ` Laurent Pinchart
2023-06-22 17:39 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).