From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF1DEB64DD for ; Wed, 5 Jul 2023 14:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232571AbjGEOo3 (ORCPT ); Wed, 5 Jul 2023 10:44:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232255AbjGEOo2 (ORCPT ); Wed, 5 Jul 2023 10:44:28 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0B3A19A3 for ; Wed, 5 Jul 2023 07:44:09 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fbc63c2e84so68222375e9.3 for ; Wed, 05 Jul 2023 07:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688568248; x=1691160248; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YmKtwavW1ZM/DLIGe88sJoG8P4s5K1xjWW1lgqiHqhQ=; b=HkDAkMRTNguX2wXY4lgtObUg9/ZDiVk/Hh0kwMJgW750mtz7FOMz57PUAdEidiL3za ivETv74tTqWsMsLSV5ZRqGo8t8KsVSbpywm4Y/E+ivFyuX1aldL9Bl3Kz3zADntgqP5u 5h870+j/MdaEV6PH5hXFshz/8rGc4ESaoGaNkvVpWw0jyoilr4mWSvfJpPjcwR79rByb XlOFmOni5Lh7WIeB9VZygBojFlTM0lDMztRa+8+AqQNznGCxqhiYvUZxgmUq1dIB+7n6 gUBti9EXH2uBmK+kHF9ZssGbIZ+C4IOYEXyB4Il7McJkEr7V6qPDoehmmu8t0G4T7+LR qMrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688568248; x=1691160248; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YmKtwavW1ZM/DLIGe88sJoG8P4s5K1xjWW1lgqiHqhQ=; b=aw1Bot8fgjR3RbeoxfiYX+PlgQKvuVeiibOeIIIPThH05oy9io7nIOdq41II6M8sVp VS6zIkKF+4DuLCO3qLn9iPlLt7xTe7HYIYATCUJ1qCD/hzwZv6s45ygEz11jAB83+8uN 8pEpNMSiHA9Y8mxCF75ZN9MfY5QLwEcojZavtXjnBCXCELV1naen6TU6Xka6SIi9TVEo QdPmLSVUFwWBYxLS7EicDoVShRgD0SUFfRkYryZNOtJV8TonrK6OcJzsNAXb3rYQVdho kRp25UdqHP/J2tLJL8gEAGagEPe0AGHIHx+S1jt0NePYTjvh/G5iL/vIUvWE79wu+MVu byIQ== X-Gm-Message-State: ABy/qLaecVRH0zSMdzpQdU3uSrs3lZgAnx9y9x36DcPWDerz0vWqcuTI Fg4aZkUfcYEdFn51BgwlWIqiZNzmHuYOVQPs9bE3Xg== X-Google-Smtp-Source: APBJJlECxIHZ1/nuhSbjtKSOWFbIVTOW/tFGCk0wGrvxbMvkpR32UFyVPy1XTc9iu8ZGmCrUUpXLIA== X-Received: by 2002:a05:600c:3785:b0:3fb:dd9c:72d2 with SMTP id o5-20020a05600c378500b003fbdd9c72d2mr5832003wmr.31.1688568248299; Wed, 05 Jul 2023 07:44:08 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id f11-20020a7bc8cb000000b003fbd04ecdc6sm2370816wml.5.2023.07.05.07.44.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 07:44:07 -0700 (PDT) Date: Wed, 5 Jul 2023 15:44:06 +0100 From: Daniel Thompson To: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Lee Jones , Jingoo Han , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: led_bl: fix initial power state Message-ID: <20230705144406.GA9021@aspen.lan> References: <20230705142447.15546-1-mans@mansr.com> <20230705143320.GE6265@aspen.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Wed, Jul 05, 2023 at 03:36:46PM +0100, Måns Rullgård wrote: > Daniel Thompson writes: > > > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: > >> The condition for the initial power state based on the default > >> brightness value is reversed. Fix it. > >> > >> Furthermore, use the actual state of the LEDs rather than the default > >> brightness specified in the devicetree as the latter should not cause > >> the backlight to be automatically turned on. > >> > >> If the backlight device is not linked to any display, set the initial > >> power to on unconditionally. > >> > >> Fixes: ae232e45acf9 ("backlight: add led-backlight driver") > >> Signed-off-by: Mans Rullgard > >> --- > >> Changes in v3: > >> - Add comment > > > > This mismatches the subject line ;-) but I can live with that if Lee > > and Jingoo can! > > Does it not fix it? If you think the subject is misleading, feel free > to change it. The bit that goes into version control is fine! However without '[PATCH v3]' on the subject line for the initial patch there is a risk this thread will get overlooked and not queued[1]. Daniel. [1] Just to be clear, Lee J. typically hoovers up the backlight patches and sends the PR. I only queue backlight patches myself as holiday cover...