From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, suijingfeng@loongson.cn, arnd@arndb.de
Cc: linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Helge Deller <deller@gmx.de>
Subject: [PATCH v2 2/4] fbdev/sm712fb: Do not include <linux/screen_info.h>
Date: Thu, 6 Jul 2023 12:42:15 +0200 [thread overview]
Message-ID: <20230706104852.27451-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20230706104852.27451-1-tzimmermann@suse.de>
Sm712fb's dependency on <linux/screen_info.h> is artificial in that
it only uses struct screen_info for its internals. Replace the use of
struct screen_info with a custom data structure and remove the include
of <linux/screen_info.h>.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Cc: Helge Deller <deller@gmx.de>
---
drivers/video/fbdev/sm712fb.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
index b7ad3c644e13..f929091da4e7 100644
--- a/drivers/video/fbdev/sm712fb.c
+++ b/drivers/video/fbdev/sm712fb.c
@@ -27,12 +27,17 @@
#include <linux/uaccess.h>
#include <linux/module.h>
#include <linux/console.h>
-#include <linux/screen_info.h>
#include <linux/pm.h>
#include "sm712.h"
+struct smtcfb_screen_info {
+ u16 lfb_width;
+ u16 lfb_height;
+ u16 lfb_depth;
+};
+
/*
* Private structure
*/
@@ -829,7 +834,7 @@ static const struct modeinit vgamode[] = {
},
};
-static struct screen_info smtc_scr_info;
+static struct smtcfb_screen_info smtc_scr_info;
static char *mode_option;
--
2.41.0
next prev parent reply other threads:[~2023-07-06 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 10:42 [PATCH v2 0/4] Remove unnecessary includes of <linux/screen_info.h> Thomas Zimmermann
2023-07-06 10:42 ` [PATCH v2 1/4] efi: Do not include <linux/screen_info.h> from EFI header Thomas Zimmermann
2023-07-06 11:36 ` Arnd Bergmann
2023-07-06 10:42 ` Thomas Zimmermann [this message]
2023-07-06 11:36 ` [PATCH v2 2/4] fbdev/sm712fb: Do not include <linux/screen_info.h> Arnd Bergmann
2023-07-06 10:42 ` [PATCH v2 3/4] sysfb: Do not include <linux/screen_info.h> from sysfb header Thomas Zimmermann
2023-07-06 11:38 ` Arnd Bergmann
2023-07-06 10:42 ` [PATCH v2 4/4] staging/sm750fb: Do not include <linux/screen_info.h> Thomas Zimmermann
2023-07-07 5:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706104852.27451-3-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=loongarch@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=suijingfeng@loongson.cn \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).