* [PATCH] fbdev/hyperv_fb: Include <linux/screen_info.h>
@ 2023-07-10 7:58 Thomas Zimmermann
2023-07-10 8:45 ` Javier Martinez Canillas
2023-07-10 20:14 ` suijingfeng
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2023-07-10 7:58 UTC (permalink / raw)
To: deller, javierm, suijingfeng, decui, wei.liu, haiyangz, kys
Cc: dri-devel, linux-fbdev, Thomas Zimmermann, kernel test robot,
Ard Biesheuvel, Russell King, Catalin Marinas, Will Deacon,
Arnd Bergmann, linux-efi, linux-hyperv
Include <linux/screen_info.h> to get the global screen_info state.
Fixes the following errors:
>> drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier 'screen_info'
1033 | base = screen_info.lfb_base;
| ^
drivers/video/fbdev/hyperv_fb.c:1034:10: error: use of undeclared identifier 'screen_info'
1034 | size = screen_info.lfb_size;
| ^
>> drivers/video/fbdev/hyperv_fb.c:1080:3: error: must use 'struct' tag to refer to type 'screen_info'
1080 | screen_info.lfb_size = 0;
| ^
| struct
>> drivers/video/fbdev/hyperv_fb.c:1080:14: error: expected identifier or '('
1080 | screen_info.lfb_size = 0;
| ^
drivers/video/fbdev/hyperv_fb.c:1081:3: error: must use 'struct' tag to refer to type 'screen_info'
1081 | screen_info.lfb_base = 0;
| ^
| struct
drivers/video/fbdev/hyperv_fb.c:1081:14: error: expected identifier or '('
1081 | screen_info.lfb_base = 0;
| ^
drivers/video/fbdev/hyperv_fb.c:1082:3: error: must use 'struct' tag to refer to type 'screen_info'
1082 | screen_info.orig_video_isVGA = 0;
| ^
| struct
drivers/video/fbdev/hyperv_fb.c:1082:14: error: expected identifier or '('
1082 | screen_info.orig_video_isVGA = 0;
| ^
8 errors generated.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307101042.rqehuauj-lkp@intel.com/
Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: "K. Y. Srinivasan" <kys@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
Cc: Haiyang Zhang <haiyangz@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
Cc: Wei Liu <wei.liu@kernel.org> (supporter:Hyper-V/Azure CORE AND DRIVERS)
Cc: Dexuan Cui <decui@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
Cc: Helge Deller <deller@gmx.de> (maintainer:FRAMEBUFFER LAYER)
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Sui Jingfeng <suijingfeng@loongson.cn>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-efi@vger.kernel.org
Cc: linux-hyperv@vger.kernel.org (open list:Hyper-V/Azure CORE AND DRIVERS)
Cc: linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER)
Cc: dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER)
---
drivers/video/fbdev/hyperv_fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
index 1ae35ab62b29..b331452aab4f 100644
--- a/drivers/video/fbdev/hyperv_fb.c
+++ b/drivers/video/fbdev/hyperv_fb.c
@@ -48,6 +48,7 @@
#include <linux/aperture.h>
#include <linux/module.h>
#include <linux/kernel.h>
+#include <linux/screen_info.h>
#include <linux/vmalloc.h>
#include <linux/init.h>
#include <linux/completion.h>
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev/hyperv_fb: Include <linux/screen_info.h>
2023-07-10 7:58 [PATCH] fbdev/hyperv_fb: Include <linux/screen_info.h> Thomas Zimmermann
@ 2023-07-10 8:45 ` Javier Martinez Canillas
2023-07-10 20:14 ` suijingfeng
1 sibling, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2023-07-10 8:45 UTC (permalink / raw)
To: Thomas Zimmermann, deller, suijingfeng, decui, wei.liu, haiyangz,
kys
Cc: dri-devel, linux-fbdev, Thomas Zimmermann, kernel test robot,
Ard Biesheuvel, Russell King, Catalin Marinas, Will Deacon,
Arnd Bergmann, linux-efi, linux-hyperv
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Include <linux/screen_info.h> to get the global screen_info state.
> Fixes the following errors:
>
>>> drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier 'screen_info'
> 1033 | base = screen_info.lfb_base;
> | ^
> drivers/video/fbdev/hyperv_fb.c:1034:10: error: use of undeclared identifier 'screen_info'
> 1034 | size = screen_info.lfb_size;
> | ^
>>> drivers/video/fbdev/hyperv_fb.c:1080:3: error: must use 'struct' tag to refer to type 'screen_info'
> 1080 | screen_info.lfb_size = 0;
> | ^
> | struct
>>> drivers/video/fbdev/hyperv_fb.c:1080:14: error: expected identifier or '('
> 1080 | screen_info.lfb_size = 0;
> | ^
> drivers/video/fbdev/hyperv_fb.c:1081:3: error: must use 'struct' tag to refer to type 'screen_info'
> 1081 | screen_info.lfb_base = 0;
> | ^
> | struct
> drivers/video/fbdev/hyperv_fb.c:1081:14: error: expected identifier or '('
> 1081 | screen_info.lfb_base = 0;
> | ^
> drivers/video/fbdev/hyperv_fb.c:1082:3: error: must use 'struct' tag to refer to type 'screen_info'
> 1082 | screen_info.orig_video_isVGA = 0;
> | ^
> | struct
> drivers/video/fbdev/hyperv_fb.c:1082:14: error: expected identifier or '('
> 1082 | screen_info.orig_video_isVGA = 0;
> | ^
> 8 errors generated.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307101042.rqehuauj-lkp@intel.com/
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: "K. Y. Srinivasan" <kys@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
> Cc: Haiyang Zhang <haiyangz@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
> Cc: Wei Liu <wei.liu@kernel.org> (supporter:Hyper-V/Azure CORE AND DRIVERS)
> Cc: Dexuan Cui <decui@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
> Cc: Helge Deller <deller@gmx.de> (maintainer:FRAMEBUFFER LAYER)
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Sui Jingfeng <suijingfeng@loongson.cn>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-efi@vger.kernel.org
> Cc: linux-hyperv@vger.kernel.org (open list:Hyper-V/Azure CORE AND DRIVERS)
> Cc: linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER)
> Cc: dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER)
> ---
> drivers/video/fbdev/hyperv_fb.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev/hyperv_fb: Include <linux/screen_info.h>
2023-07-10 7:58 [PATCH] fbdev/hyperv_fb: Include <linux/screen_info.h> Thomas Zimmermann
2023-07-10 8:45 ` Javier Martinez Canillas
@ 2023-07-10 20:14 ` suijingfeng
1 sibling, 0 replies; 3+ messages in thread
From: suijingfeng @ 2023-07-10 20:14 UTC (permalink / raw)
To: Thomas Zimmermann, deller, javierm, decui, wei.liu, haiyangz, kys
Cc: dri-devel, linux-fbdev, kernel test robot, Ard Biesheuvel,
Russell King, Catalin Marinas, Will Deacon, Arnd Bergmann,
linux-efi, linux-hyperv
Hi,
On 2023/7/10 15:58, Thomas Zimmermann wrote:
> Include <linux/screen_info.h> to get the global screen_info state.
> Fixes the following errors:
>
>>> drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier 'screen_info'
> 1033 | base = screen_info.lfb_base;
> | ^
> drivers/video/fbdev/hyperv_fb.c:1034:10: error: use of undeclared identifier 'screen_info'
> 1034 | size = screen_info.lfb_size;
> | ^
>>> drivers/video/fbdev/hyperv_fb.c:1080:3: error: must use 'struct' tag to refer to type 'screen_info'
> 1080 | screen_info.lfb_size = 0;
> | ^
> | struct
>>> drivers/video/fbdev/hyperv_fb.c:1080:14: error: expected identifier or '('
> 1080 | screen_info.lfb_size = 0;
> | ^
> drivers/video/fbdev/hyperv_fb.c:1081:3: error: must use 'struct' tag to refer to type 'screen_info'
> 1081 | screen_info.lfb_base = 0;
> | ^
> | struct
> drivers/video/fbdev/hyperv_fb.c:1081:14: error: expected identifier or '('
> 1081 | screen_info.lfb_base = 0;
> | ^
> drivers/video/fbdev/hyperv_fb.c:1082:3: error: must use 'struct' tag to refer to type 'screen_info'
> 1082 | screen_info.orig_video_isVGA = 0;
> | ^
> | struct
> drivers/video/fbdev/hyperv_fb.c:1082:14: error: expected identifier or '('
> 1082 | screen_info.orig_video_isVGA = 0;
> | ^
> 8 errors generated.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307101042.rqehuauj-lkp@intel.com/
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>
> Cc: "K. Y. Srinivasan" <kys@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
> Cc: Haiyang Zhang <haiyangz@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
> Cc: Wei Liu <wei.liu@kernel.org> (supporter:Hyper-V/Azure CORE AND DRIVERS)
> Cc: Dexuan Cui <decui@microsoft.com> (supporter:Hyper-V/Azure CORE AND DRIVERS)
> Cc: Helge Deller <deller@gmx.de> (maintainer:FRAMEBUFFER LAYER)
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Sui Jingfeng <suijingfeng@loongson.cn>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-efi@vger.kernel.org
> Cc: linux-hyperv@vger.kernel.org (open list:Hyper-V/Azure CORE AND DRIVERS)
> Cc: linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER)
> Cc: dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER)
> ---
> drivers/video/fbdev/hyperv_fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
> index 1ae35ab62b29..b331452aab4f 100644
> --- a/drivers/video/fbdev/hyperv_fb.c
> +++ b/drivers/video/fbdev/hyperv_fb.c
> @@ -48,6 +48,7 @@
> #include <linux/aperture.h>
> #include <linux/module.h>
> #include <linux/kernel.h>
> +#include <linux/screen_info.h>
> #include <linux/vmalloc.h>
> #include <linux/init.h>
> #include <linux/completion.h>
Ah, I also overlook this one. :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-10 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-10 7:58 [PATCH] fbdev/hyperv_fb: Include <linux/screen_info.h> Thomas Zimmermann
2023-07-10 8:45 ` Javier Martinez Canillas
2023-07-10 20:14 ` suijingfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).