* [PATCH] backlight: qcom-wled: Explicitly include correct DT includes
@ 2023-07-14 17:50 Rob Herring
2023-07-28 9:01 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2023-07-14 17:50 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Daniel Thompson, Jingoo Han, Helge Deller
Cc: devicetree, linux-arm-msm, dri-devel, linux-fbdev, linux-kernel
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/video/backlight/qcom-wled.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index c6996aa288e6..10129095a4c1 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c
@@ -9,8 +9,8 @@
#include <linux/backlight.h>
#include <linux/module.h>
#include <linux/of.h>
-#include <linux/of_device.h>
#include <linux/of_address.h>
+#include <linux/platform_device.h>
#include <linux/regmap.h>
/* From DT binding */
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] backlight: qcom-wled: Explicitly include correct DT includes
2023-07-14 17:50 [PATCH] backlight: qcom-wled: Explicitly include correct DT includes Rob Herring
@ 2023-07-28 9:01 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-07-28 9:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Daniel Thompson, Jingoo Han, Helge Deller, Rob Herring
Cc: devicetree, linux-arm-msm, dri-devel, linux-fbdev, linux-kernel
On Fri, 14 Jul 2023 11:50:29 -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> [...]
Applied, thanks!
[1/1] backlight: qcom-wled: Explicitly include correct DT includes
commit: 1bb5187b673208f7191f227249ffe7401e969b97
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-28 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-14 17:50 [PATCH] backlight: qcom-wled: Explicitly include correct DT includes Rob Herring
2023-07-28 9:01 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).