From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Raphael Gallais-Pou <rgallaispou@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER
Date: Tue, 18 Jul 2023 15:33:35 +0200 [thread overview]
Message-ID: <2023071817-enslave-unlovable-f8ae@gregkh> (raw)
In-Reply-To: <20230718081759.28902-1-rgallaispou@gmail.com>
On Tue, Jul 18, 2023 at 10:17:59AM +0200, Raphael Gallais-Pou wrote:
> Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
> ultimately causes a warning when the module probes. Fixes it.
>
> Changes in v2:
> - dropped MODULE_ALIAS changes
> - changed commit log for more accurate description
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
> drivers/staging/fbtft/fb_ili9341.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why is this a resend?
And the changes need to go below the --- line as per the documentation.
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-18 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 8:17 [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER Raphael Gallais-Pou
2023-07-18 13:33 ` Greg Kroah-Hartman [this message]
2023-07-18 16:55 ` Raphaël Gallais-Pou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071817-enslave-unlovable-f8ae@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rgallaispou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).