From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DA6EB64DC for ; Fri, 21 Jul 2023 08:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229671AbjGUInB (ORCPT ); Fri, 21 Jul 2023 04:43:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbjGUIm7 (ORCPT ); Fri, 21 Jul 2023 04:42:59 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AECA82D50 for ; Fri, 21 Jul 2023 01:42:55 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fd18b1d924so13573205e9.1 for ; Fri, 21 Jul 2023 01:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689928974; x=1690533774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XQaE+aGAoPiWTrzxC0m23eci3gy8Nzf0koJxtpNK2YA=; b=N2h3UNJDdhqd87L3F4mYmBXLz0qK1XjoAFFJkLXJL1KKoYmOgmauzLv185j/ocWYA5 R3etvIdFfA2ZAkggjQMd+poAmzQfVSvcsKMAoR3TgARskd/Rqg5htrh0tAqZFbm020Q6 EhTfIwPbnUM8RX+KkLUC/QvNUXBwqtk05iaLgVGW5/ml0lYCOH9AAQiG2jw9/OVbQTYd sPYqSXzbVvHjiO297NGcXQMx+BbECWhZsHR6Z2eL2XqeB/IvWoqSLhivGEkxUMN50hlg 6G5rCstvluru5Nbve2rK0+JFlo4a/7uf7gcJKLy6AYImNAoLJDVS4tn2rrKhZpSALEYU +V3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689928974; x=1690533774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XQaE+aGAoPiWTrzxC0m23eci3gy8Nzf0koJxtpNK2YA=; b=OsFwQb4jNHjlweWaeYsY0Qel/PsL+EGN9N1oXnIoE8xp9SCrSdBFiZvlo6UAqupGH9 O9mvDGa8eGj3XnwERgb8iwCcF1AZZhWlVHTW3z25b2Pcxr0uwUN8TvAnQSf40e2Qrg8M yC83DguZB2fpU8fmHC8IfWlw/GAEHM1V2IEPYL/CeZ3B7qekHz2oWEZqOYaS+dA/2Vou cXMQB+YISFyApJ8uYwwI3fT7X7UOF/3XGol+qPH28LVWObrWJqKcCVR9F4V15IPWVNa0 0NNmtD1AE6DwNaUMwpTTyvvGNe7VlSAi5YsIowH13QMLXeLVfu48p/nVfHkiv41vHWv3 Z/qQ== X-Gm-Message-State: ABy/qLZUxaBllJcaZobylyhebyrHot+9yo/V+jcazwRDo2i9PAgfP3EP kMzhSRSb/Eo959boquKwfzAuFQ== X-Google-Smtp-Source: APBJJlE3K30Gc1FY8KUg8IGeriUSJfp+eK3+VTcAwyFZWEeBiWs4OcFMYvjx+IJ5eAdxug70zn9QFQ== X-Received: by 2002:a5d:6ac8:0:b0:317:15f5:a1ca with SMTP id u8-20020a5d6ac8000000b0031715f5a1camr925360wrw.10.1689928974175; Fri, 21 Jul 2023 01:42:54 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id u1-20020adfdb81000000b0030e5bd253aasm3564628wri.39.2023.07.21.01.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 01:42:53 -0700 (PDT) Date: Fri, 21 Jul 2023 09:42:51 +0100 From: Daniel Thompson To: Ying Liu Cc: "dri-devel@lists.freedesktop.org" , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lee@kernel.org" , "jingoohan1@gmail.com" , "deller@gmx.de" , "andy@kernel.org" , "linus.walleij@linaro.org" , "brgl@bgdev.pl" Subject: Re: [PATCH v2] backlight: gpio_backlight: Drop output gpio direction check for initial power state Message-ID: <20230721084251.GF2525277@aspen.lan> References: <20230721073555.1377236-1-victor.liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721073555.1377236-1-victor.liu@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, Jul 21, 2023 at 07:31:37AM +0000, Ying Liu wrote: > If gpio pin is in input state but backlight is currently off due to > default pull downs, then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effectively > turned on in gpio_backlight_probe(), which is undesirable according to > patch description of commit ec665b756e6f ("backlight: gpio-backlight: > Correct initial power state handling"). > > Quote: > --- > If in DT boot we have phandle link then leave the GPIO in a state which the > bootloader left it and let the user of the backlight to configure it further. > --- > > So, let's drop output gpio direction check and only check gpio value to set > the initial power state. > > Signed-off-by: Liu Ying Based on the discussion for v1 about 706dc68102bc ("backlight: gpio: Explicitly set the direction of the GPIO"), I think there should be a Fixes: tag here. Daniel.