From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com, sam@ravnborg.org
Cc: linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-geode@lists.infradead.org, linux-omap@vger.kernel.org,
kvm@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>,
Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH v2 39/47] fbdev/simplefb: Use fbdev I/O helpers
Date: Tue, 1 Aug 2023 12:13:44 +0200 [thread overview]
Message-ID: <20230801101541.900-40-tzimmermann@suse.de> (raw)
In-Reply-To: <20230801101541.900-1-tzimmermann@suse.de>
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IO_HELPERS token.
The macro and token set the currently selected values, so there is
no functional change.
v2:
* updated to use _IOMEM_ tokens
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Cc: Hans de Goede <hdegoede@redhat.com>
---
drivers/video/fbdev/Kconfig | 4 +---
drivers/video/fbdev/simplefb.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index cea3e00badcd..9b11a394bd82 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1939,9 +1939,7 @@ config FB_SIMPLE
depends on FB
depends on !DRM_SIMPLEDRM
select APERTURE_HELPERS
- select FB_CFB_FILLRECT
- select FB_CFB_COPYAREA
- select FB_CFB_IMAGEBLIT
+ select FB_IOMEM_HELPERS
help
Say Y if you want support for a simple frame-buffer.
diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index 461e50c8dd1b..62f99f6fccd3 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -109,11 +109,9 @@ static void simplefb_destroy(struct fb_info *info)
static const struct fb_ops simplefb_ops = {
.owner = THIS_MODULE,
+ FB_DEFAULT_IOMEM_OPS,
.fb_destroy = simplefb_destroy,
.fb_setcolreg = simplefb_setcolreg,
- .fb_fillrect = cfb_fillrect,
- .fb_copyarea = cfb_copyarea,
- .fb_imageblit = cfb_imageblit,
};
static struct simplefb_format simplefb_formats[] = SIMPLEFB_FORMATS;
--
2.41.0
next prev parent reply other threads:[~2023-08-01 10:16 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 10:13 [PATCH v2 00/47] fbdev: Use I/O helpers Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 01/47] media/vivid: Use fbdev " Thomas Zimmermann
2023-08-01 11:22 ` Hans Verkuil
2023-08-01 16:54 ` Thomas Zimmermann
2023-08-02 7:34 ` Hans Verkuil
2023-08-01 10:13 ` [PATCH v2 02/47] fbdev/acornfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 03/47] fbdev/asiliantfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 04/47] fbdev/atmel_lcdfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 05/47] fbdev/aty128fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 06/47] fbdev/carminefb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 07/47] fbdev/chipsfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 08/47] fbdev/da8xx-fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 09/47] fbdev/efifb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 10/47] fbdev/fm2fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 11/47] fbdev/fsl-diu-fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 12/47] fbdev/g364fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 13/47] fbdev/geode/gx1fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 14/47] fbdev/geode/gxfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 15/47] fbdev/geode/lxfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 16/47] fbdev/goldfishfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 17/47] fbdev/grvga: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 18/47] fbdev/gxt4500: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 19/47] fbdev/i740fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 20/47] fbdev/imxfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 21/47] fbdev/kyro: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 22/47] fbdev/macfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 23/47] fbdev/maxinefb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 24/47] fbdev/mb862xxfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 25/47] fbdev/mmpfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 26/47] fbdev/mx3fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 27/47] fbdev/ocfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 28/47] fbdev/offb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 29/47] fbdev/omapfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 30/47] fbdev/platinumfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 31/47] fbdev/pmag-aa-fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 32/47] fbdev/pmag-ba-fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 33/47] fbdev/pmagb-b-fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 34/47] fbdev/pxa168fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 35/47] fbdev/pxafb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 36/47] fbdev/q40fb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 37/47] fbdev/s3cfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 38/47] fbdev/sh7760fb: " Thomas Zimmermann
2023-08-01 10:13 ` Thomas Zimmermann [this message]
2023-08-01 10:13 ` [PATCH v2 40/47] fbdev/sstfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 41/47] fbdev/sunxvr1000: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 42/47] fbdev/sunxvr2500: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 43/47] fbdev/uvesafb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 44/47] fbdev/valkyriefb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 45/47] fbdev/vesafb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 46/47] fbdev/xilinxfb: " Thomas Zimmermann
2023-08-01 10:13 ` [PATCH v2 47/47] vfio-dev/mdpy-fb: " Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801101541.900-40-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=javierm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).