linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com, sam@ravnborg.org,
	arnd@arndb.de, daniel@ffwll.ch
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-nvidia@lists.surfsouth.com, linux-omap@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Antonino Daplas <adaplas@gmail.com>
Subject: [PATCH 19/46] fbdev/i810fb: Initialize fb_ops to fbdev I/O-memory helpers
Date: Wed, 27 Sep 2023 09:26:52 +0200	[thread overview]
Message-ID: <20230927074722.6197-20-tzimmermann@suse.de> (raw)
In-Reply-To: <20230927074722.6197-1-tzimmermann@suse.de>

Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Antonino Daplas <adaplas@gmail.com>
---
 drivers/video/fbdev/Kconfig          | 4 +---
 drivers/video/fbdev/i810/i810_main.c | 2 ++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 3c28bff8a0770..e42439cfb1a1d 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -793,10 +793,8 @@ config FB_I740
 config FB_I810
 	tristate "Intel 810/815 support"
 	depends on FB && PCI && X86_32 && AGP_INTEL
+	select FB_IOMEM_FOPS
 	select FB_MODE_HELPERS
-	select FB_CFB_FILLRECT
-	select FB_CFB_COPYAREA
-	select FB_CFB_IMAGEBLIT
 	select VGASTATE
 	select VIDEO_NOMODESET
 	help
diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index f5511bb4fadca..d73a795fe1bef 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -1547,6 +1547,7 @@ static const struct fb_ops i810fb_ops = {
 	.owner =             THIS_MODULE,
 	.fb_open =           i810fb_open,
 	.fb_release =        i810fb_release,
+	__FB_DEFAULT_IOMEM_OPS_RDWR,
 	.fb_check_var =      i810fb_check_var,
 	.fb_set_par =        i810fb_set_par,
 	.fb_setcolreg =      i810fb_setcolreg,
@@ -1557,6 +1558,7 @@ static const struct fb_ops i810fb_ops = {
 	.fb_imageblit =      i810fb_imageblit,
 	.fb_cursor =         i810fb_cursor,
 	.fb_sync =           i810fb_sync,
+	__FB_DEFAULT_IOMEM_OPS_MMAP,
 };
 
 /***********************************************************************
-- 
2.42.0


  parent reply	other threads:[~2023-09-27  7:47 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27  7:26 [PATCH 00/46] fbdev: Init fb_ops with helpers for I/O memory Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 01/46] fbdev: Provide I/O-memory helpers as module Thomas Zimmermann
2023-10-18  8:16   ` Javier Martinez Canillas
2023-09-27  7:26 ` [PATCH 02/46] fbdev/68328fb: Initialize fb_ops to fbdev I/O-memory helpers Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 03/46] fbdev/amba-clcd: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 04/46] fbdev/amifb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 05/46] fbdev/arkfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 06/46] fbdev/atafb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 07/46] fbdev/atyfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 08/46] fbdev/au1100fb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 09/46] fbdev/cirrusfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 10/46] fbdev/cobalt-lcd: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 11/46] fbdev/controlfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 12/46] fbdev/cyber2000fb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 13/46] fbdev/dnfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 14/46] fbdev/ep93xx-fb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 15/46] fbdev/gbefb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 16/46] fbdev/hgafb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 17/46] fbdev/hitfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 18/46] fbdev/hpfb: " Thomas Zimmermann
2023-09-27  7:26 ` Thomas Zimmermann [this message]
2023-09-27  7:26 ` [PATCH 20/46] fbdev/imsttfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 21/46] fbdev/intelfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 22/46] fbdev/matroxfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 23/46] fbdev/neofb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 24/46] fbdev/nvidiafb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 25/46] fbdev/omapfb: " Thomas Zimmermann
2023-09-27  7:26 ` [PATCH 26/46] fbdev/pm2fb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 27/46] fbdev/pm3fb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 28/46] fbdev/pvr2fb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 29/46] fbdev/radeon: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 30/46] fbdev/rivafb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 31/46] fbdev/s1d13xxxfb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 32/46] fbdev/s3fb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 33/46] fbdev/sa1100fb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 34/46] fbdev/savagefb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 35/46] fbdev/sisfb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 36/46] fbdev/sm501fb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 37/46] fbdev/sm712fb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 38/46] fbdev/stifb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 39/46] fbdev/sunxvr500: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 40/46] fbdev/tdfxfb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 41/46] fbdev/tgafb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 42/46] fbdev/tridentfb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 43/46] fbdev/vermilionfb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 44/46] fbdev/vga16fb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 45/46] fbdev/viafb: " Thomas Zimmermann
2023-09-27  7:27 ` [PATCH 46/46] fbdev/vt8623fb: " Thomas Zimmermann
2023-10-18  8:25 ` [PATCH 00/46] fbdev: Init fb_ops with helpers for I/O memory Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927074722.6197-20-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=adaplas@gmail.com \
    --cc=arnd@arndb.de \
    --cc=daniel@ffwll.ch \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-nvidia@lists.surfsouth.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).