From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16F1E81E02 for ; Fri, 6 Oct 2023 14:41:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231418AbjJFOlR (ORCPT ); Fri, 6 Oct 2023 10:41:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbjJFOlQ (ORCPT ); Fri, 6 Oct 2023 10:41:16 -0400 X-Greylist: delayed 425 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 06 Oct 2023 07:41:16 PDT Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3C7ADC6 for ; Fri, 6 Oct 2023 07:41:15 -0700 (PDT) Received: from [192.168.1.3] (gsystem.sk [85.248.217.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id AEDAA7A025C; Fri, 6 Oct 2023 16:34:09 +0200 (CEST) From: Ondrej Zary To: Helge Deller Subject: Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak Date: Fri, 6 Oct 2023 16:34:01 +0200 User-Agent: KMail/1.9.10 Cc: Zhang Shurong , tzimmermann@suse.de, jiapeng.chong@linux.alibaba.com, javierm@redhat.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: In-Reply-To: X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <202310061634.02110.linux@zary.sk> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Friday 06 October 2023, Helge Deller wrote: > On 10/5/23 09:01, Zhang Shurong wrote: > > Add missing pci_disable_device() in error path in ark_pci_probe(). > > Do you have this hardware and tested your patch? > I'm sure there is a reason, why "pci_disable_device()" was commented > out in the original submission in commit 681e14730c73c... pci_disable_device() call is disabled in many fbdev drivers because calling it might prevent display from working. > > Additionally I'm wondering why your patch doesn't show up in > the fbdev patchwork, although you added linux-fbdev mailing list. > Probably a vger issue. > > Helge > > > > Signed-off-by: Zhang Shurong > > --- > > drivers/video/fbdev/arkfb.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c > > index 60a96fdb5dd8..6c4e5065646f 100644 > > --- a/drivers/video/fbdev/arkfb.c > > +++ b/drivers/video/fbdev/arkfb.c > > @@ -1064,7 +1064,7 @@ static int ark_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) > > err_dac: > > pci_release_regions(dev); > > err_request_regions: > > -/* pci_disable_device(dev); */ > > + pci_disable_device(dev); > > err_enable_device: > > framebuffer_release(info); > > return rc; > > @@ -1085,7 +1085,7 @@ static void ark_pci_remove(struct pci_dev *dev) > > > > pci_iounmap(dev, info->screen_base); > > pci_release_regions(dev); > > -/* pci_disable_device(dev); */ > > + pci_disable_device(dev); > > > > framebuffer_release(info); > > } > > -- Ondrej Zary