From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E8DCDB474 for ; Tue, 17 Oct 2023 08:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234667AbjJQIet (ORCPT ); Tue, 17 Oct 2023 04:34:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234708AbjJQIes (ORCPT ); Tue, 17 Oct 2023 04:34:48 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDD22E8; Tue, 17 Oct 2023 01:34:46 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5CC8C433C7; Tue, 17 Oct 2023 08:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697531686; bh=cjDjO6PGPcTTJY+/Yg1XGUcSwRarZe6dK3IlxmRulQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rRU59vNpXQuIVFnrJ+f6DXxM9qkxDIR7ENM1LANhCJNHDk3Dr5wTuRpykOnLPbTya NHinw/DcDWDg+SPzBok8lba60YXRUPXeNRI6NrwoqUMn8RTXn14QebpWtwGa2cL+Gm 7SQxnp8Z83kGMr4Y+jPSBhPofqPbinAfkKcLdLlE= Date: Tue, 17 Oct 2023 10:34:43 +0200 From: Greg Kroah-Hartman To: Dorcas Litunya Cc: outreachy@lists.linux.dev, julia.lawall@inria.fr, dan.carpenter@linaro.org, Sudip Mukherjee , Teddy Wang , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, andi.shyti@linux.intel.com Subject: Re: [PATCH v2 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E Message-ID: <2023101712-grudge-overtime-1f43@gregkh> References: <20231016201434.7880-1-anonolitunya@gmail.com> <20231016201434.7880-2-anonolitunya@gmail.com> <2023101724-diagram-legwork-0e53@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Oct 17, 2023 at 11:28:06AM +0300, Dorcas Litunya wrote: > On Tue, Oct 17, 2023 at 09:50:50AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Oct 16, 2023 at 11:14:08PM +0300, Dorcas AnonoLitunya wrote: > > > Rename function displayControlAdjust_SM750E to > > > display_control_adjust_SM750E. This follows snakecase naming convention > > > and ensures a consistent naming style throughout the file. Issue found by > > > checkpatch. > > > > > > Mutes the following error: > > > CHECK:Avoid CamelCase: > > > > > > Signed-off-by: Dorcas AnonoLitunya > > > --- > > > drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c > > > index e00a6cb31947..8708995f676c 100644 > > > --- a/drivers/staging/sm750fb/ddk750_mode.c > > > +++ b/drivers/staging/sm750fb/ddk750_mode.c > > > @@ -14,8 +14,8 @@ > > > * in bit 29:27 of Display Control register. > > > */ > > > static unsigned long > > > -displayControlAdjust_SM750LE(struct mode_parameter *pModeParam, > > > - unsigned long dispControl) > > > +display_control_adjust_SM750LE(struct mode_parameter *pModeParam, > > > + unsigned long dispControl) > > > { > > > unsigned long x, y; > > > > > > @@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, > > > tmp |= DISPLAY_CTRL_HSYNC_PHASE; > > > > > > if (sm750_get_chip_type() == SM750LE) { > > > - displayControlAdjust_SM750LE(pModeParam, tmp); > > > + display_control_adjust_SM750LE(pModeParam, tmp); > > > > Why is this function returning a value if it is just being ignored? > > > > It's not the issue here in the patch, but for future changes. > > > Hi Greg, > > I will do the correction in the next patchset to correct both functions > return value as this patchset was not focused on that. Does this mean > that this patchset has been accepted? Or should I submit another > patchset that includes the two changes suggested on function return > values? You'll get an email from my system when it is accepted, wait a day or so before worrying about that. And then send new patches on top of them then. thanks, greg k-h