From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dorcas AnonoLitunya <anonolitunya@gmail.com>
Cc: outreachy@lists.linux.dev, julia.lawall@inria.fr,
dan.carpenter@linaro.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E
Date: Tue, 17 Oct 2023 09:50:50 +0200 [thread overview]
Message-ID: <2023101724-diagram-legwork-0e53@gregkh> (raw)
In-Reply-To: <20231016201434.7880-2-anonolitunya@gmail.com>
On Mon, Oct 16, 2023 at 11:14:08PM +0300, Dorcas AnonoLitunya wrote:
> Rename function displayControlAdjust_SM750E to
> display_control_adjust_SM750E. This follows snakecase naming convention
> and ensures a consistent naming style throughout the file. Issue found by
> checkpatch.
>
> Mutes the following error:
> CHECK:Avoid CamelCase: <displayControlAdjust_SM750E>
>
> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index e00a6cb31947..8708995f676c 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -14,8 +14,8 @@
> * in bit 29:27 of Display Control register.
> */
> static unsigned long
> -displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> - unsigned long dispControl)
> +display_control_adjust_SM750LE(struct mode_parameter *pModeParam,
> + unsigned long dispControl)
> {
> unsigned long x, y;
>
> @@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam,
> tmp |= DISPLAY_CTRL_HSYNC_PHASE;
>
> if (sm750_get_chip_type() == SM750LE) {
> - displayControlAdjust_SM750LE(pModeParam, tmp);
> + display_control_adjust_SM750LE(pModeParam, tmp);
Why is this function returning a value if it is just being ignored?
It's not the issue here in the patch, but for future changes.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-17 7:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 20:14 [PATCH v2 0/5] staging: sm750fb: Renaming camelcase to snakecase Dorcas AnonoLitunya
2023-10-16 20:14 ` [PATCH v2 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E Dorcas AnonoLitunya
2023-10-16 21:32 ` Andi Shyti
2023-10-17 9:04 ` Dorcas Litunya
2023-10-17 7:50 ` Greg Kroah-Hartman [this message]
2023-10-17 8:28 ` Dorcas Litunya
2023-10-17 8:34 ` Greg Kroah-Hartman
2023-10-17 8:44 ` Dorcas Litunya
2023-10-17 18:47 ` Dorcas Litunya
2023-10-18 13:27 ` Greg Kroah-Hartman
2023-10-16 20:14 ` [PATCH v2 2/5] Staging: sm750fb: Rename pModeParam Dorcas AnonoLitunya
2023-10-16 20:14 ` [PATCH v2 3/5] Staging: sm750fb: Rename dispControl Dorcas AnonoLitunya
2023-10-16 20:14 ` [PATCH v2 4/5] Staging: sm750fb: Rename programModeRegisters Dorcas AnonoLitunya
2023-10-17 7:51 ` Greg Kroah-Hartman
2023-10-16 20:14 ` [PATCH v2 5/5] Staging: sm750fb: Rename ddk750_setModeTiming Dorcas AnonoLitunya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101724-diagram-legwork-0e53@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=anonolitunya@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=julia.lawall@inria.fr \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).