From: Conor Dooley <conor@kernel.org>
To: Flavio Suligoi <f.suligoi@asem.it>
Cc: Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: backlight: mp3309c: remove two required properties
Date: Fri, 20 Oct 2023 16:59:23 +0100 [thread overview]
Message-ID: <20231020-moonrise-senate-86d0edb2d404@spud> (raw)
In-Reply-To: <20231020135434.2598578-2-f.suligoi@asem.it>
[-- Attachment #1: Type: text/plain, Size: 2195 bytes --]
Yo,
On Fri, Oct 20, 2023 at 03:54:33PM +0200, Flavio Suligoi wrote:
> The two properties:
>
> - max-brightness
> - default brightness
>
> are not really required, so they can be removed from the "required"
> section.
Why are they not required? You need to provide an explanation.
> Other changes:
>
> - improve the backlight working mode description, in the "description"
> section
> - update the example, removing the "max-brightness" and introducing the
> "brightess-levels" property
Why is this more useful?
Cheers,
Conor.
>
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> ---
> .../bindings/leds/backlight/mps,mp3309c.yaml | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> index 4191e33626f5..527a37368ed7 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> @@ -14,8 +14,8 @@ description: |
> programmable switching frequency to optimize efficiency.
> It supports two different dimming modes:
>
> - - analog mode, via I2C commands (default)
> - - PWM controlled mode.
> + - analog mode, via I2C commands, as default mode (32 dimming levels)
> + - PWM controlled mode (optional)
>
> The datasheet is available at:
> https://www.monolithicpower.com/en/mp3309c.html
> @@ -50,8 +50,6 @@ properties:
> required:
> - compatible
> - reg
> - - max-brightness
> - - default-brightness
>
> unevaluatedProperties: false
>
> @@ -66,8 +64,8 @@ examples:
> compatible = "mps,mp3309c";
> reg = <0x17>;
> pwms = <&pwm1 0 3333333 0>; /* 300 Hz --> (1/f) * 1*10^9 */
> - max-brightness = <100>;
> - default-brightness = <80>;
> + brightness-levels = <0 4 8 16 32 64 128 255>;
> + default-brightness = <6>;
> mps,overvoltage-protection-microvolt = <24000000>;
> };
> };
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-20 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 13:54 [PATCH 0/1] dt-bindings: backlight: mp3309c: remove two required properties Flavio Suligoi
2023-10-20 13:54 ` [PATCH 1/1] " Flavio Suligoi
2023-10-20 15:59 ` Conor Dooley [this message]
2023-10-23 9:28 ` Flavio Suligoi
2023-10-23 16:29 ` Conor Dooley
2023-10-24 7:53 ` Flavio Suligoi
2023-10-24 15:08 ` Conor Dooley
2023-10-25 7:02 ` Flavio Suligoi
2023-10-20 13:54 ` [PATCH v5] backlight: mp3309c: Add support for MPS MP3309C Flavio Suligoi
2023-10-20 15:56 ` Conor Dooley
2023-10-23 9:11 ` Flavio Suligoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020-moonrise-senate-86d0edb2d404@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.suligoi@asem.it \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox