From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAFF8C4332F for ; Sun, 29 Oct 2023 23:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232017AbjJ2XFM (ORCPT ); Sun, 29 Oct 2023 19:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231657AbjJ2XEa (ORCPT ); Sun, 29 Oct 2023 19:04:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 341A16FAC; Sun, 29 Oct 2023 16:01:52 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D06F4C04E60; Sun, 29 Oct 2023 23:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698620512; bh=dOPID+WAHBe+1C/wlvaKW7GPyApeXN5OKVtbv1qYIlE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wm11wqUQKvOL7OLmTUD45S3v6ThqrM8zwoN4ykan40DbdBX6tVTFcvNr6+ZtbFBex gTlnkT0fNPKKc28361qUSQyQn7YWafidDlvTFVXeaBZNgUzHHg1ojNdTCGVFEv8uEb yLPPdahO53UAf2vDsfr/wlwpAa9SFzSgIoHIL08WErSggqr0PyoBv9VY17FjDtdzBe M32V057PRVUEaEJm2Wu+3sTXhIEb4zooPRHMUfoAWTB13u2iG0LntNKYuPa/J84HH0 HQKQ0+YfWFtgfyinWq8o8QmnPwPHVZ/+BRZ8UMCAD8wXuNYDU0fGTlobw//ZHD5nFV ZyX9NginlYyYA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sergey Shtylyov , Helge Deller , Sasha Levin , daniel@ffwll.ch, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.19 08/12] fbdev: core: cfbcopyarea: fix sloppy typing Date: Sun, 29 Oct 2023 19:01:21 -0400 Message-ID: <20231029230135.793281-8-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231029230135.793281-1-sashal@kernel.org> References: <20231029230135.793281-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.297 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org From: Sergey Shtylyov [ Upstream commit 7f33df94cf0156f64eee9509bd9b4a178990f613 ] In cfb_copyarea(), the local variable bits_per_line is needlessly typed as *unsigned long* -- which is a 32-bit type on the 32-bit arches and a 64-bit type on the 64-bit arches; that variable's value is derived from the __u32 typed fb_fix_screeninfo::line_length field (multiplied by 8u) and a 32-bit *unsigned int* type should still be enough to store the # of bits per line. Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Signed-off-by: Sergey Shtylyov Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/core/cfbcopyarea.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/cfbcopyarea.c b/drivers/video/fbdev/core/cfbcopyarea.c index 6d4bfeecee350..5b80bf3dae504 100644 --- a/drivers/video/fbdev/core/cfbcopyarea.c +++ b/drivers/video/fbdev/core/cfbcopyarea.c @@ -382,7 +382,7 @@ void cfb_copyarea(struct fb_info *p, const struct fb_copyarea *area) { u32 dx = area->dx, dy = area->dy, sx = area->sx, sy = area->sy; u32 height = area->height, width = area->width; - unsigned long const bits_per_line = p->fix.line_length*8u; + unsigned int const bits_per_line = p->fix.line_length * 8u; unsigned long __iomem *base = NULL; int bits = BITS_PER_LONG, bytes = bits >> 3; unsigned dst_idx = 0, src_idx = 0, rev_copy = 0; -- 2.42.0