From: Daniel Thompson <daniel.thompson@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Flavio Suligoi <f.suligoi@asem.it>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties
Date: Fri, 15 Dec 2023 16:11:02 +0000 [thread overview]
Message-ID: <20231215161102.GA662726@aspen.lan> (raw)
In-Reply-To: <20231214195158.1335727-2-andriy.shevchenko@linux.intel.com>
On Thu, Dec 14, 2023 at 09:51:13PM +0200, Andy Shevchenko wrote:
> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
>
> Add mod_devicetable.h include.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/video/backlight/mp3309c.c | 38 ++++++++++++-------------------
> 1 file changed, 15 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c
> index 34d71259fac1..d9b08f191999 100644
> --- a/drivers/video/backlight/mp3309c.c
> +++ b/drivers/video/backlight/mp3309c.c
> @@ -15,6 +15,8 @@
> #include <linux/delay.h>
> #include <linux/gpio/consumer.h>
> #include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/property.h>
> #include <linux/pwm.h>
> #include <linux/regmap.h>
>
> @@ -202,15 +204,12 @@ static const struct backlight_ops mp3309c_bl_ops = {
> static int pm3309c_parse_dt_node(struct mp3309c_chip *chip,
Pretty minor... but I wonder if it should be renamed:
mp3309c_parse_fwnode().
Daniel.
next prev parent reply other threads:[~2023-12-15 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 19:51 [PATCH v1 0/2] backlight: mp3309c: Allow to use on non-OF platforms Andy Shevchenko
2023-12-14 19:51 ` [PATCH v1 1/2] backlight: mp3309c: Make use of device properties Andy Shevchenko
2023-12-15 14:13 ` Flavio Suligoi
2023-12-15 16:11 ` Daniel Thompson [this message]
2023-12-15 16:28 ` Andy Shevchenko
2023-12-18 7:58 ` Flavio Suligoi
2023-12-14 19:51 ` [PATCH v1 2/2] backlight: mp3309c: Utilise temporary variable for struct device Andy Shevchenko
2023-12-15 14:13 ` Flavio Suligoi
2023-12-15 16:11 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215161102.GA662726@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.suligoi@asem.it \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).