From: Thomas Zimmermann <tzimmermann@suse.de>
To: drawat.floss@gmail.com, javierm@redhat.com, deller@gmx.de,
decui@microsoft.com, wei.liu@kernel.org, haiyangz@microsoft.com,
kys@microsoft.com, daniel@ffwll.ch, airlied@gmail.com
Cc: linux-hyperv@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 4/4] fbdev/hyperv_fb: Do not clear global screen_info
Date: Wed, 3 Jan 2024 11:15:12 +0100 [thread overview]
Message-ID: <20240103102640.31751-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20240103102640.31751-1-tzimmermann@suse.de>
Do not clear the global instance of screen_info. If necessary, clearing
fields in screen_info should be done by architecture or firmware code
that maintains the firmware framebuffer.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/fbdev/hyperv_fb.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
index 76c956b9a321..7d5717805c0b 100644
--- a/drivers/video/fbdev/hyperv_fb.c
+++ b/drivers/video/fbdev/hyperv_fb.c
@@ -48,7 +48,6 @@
#include <linux/aperture.h>
#include <linux/module.h>
#include <linux/kernel.h>
-#include <linux/screen_info.h>
#include <linux/vmalloc.h>
#include <linux/init.h>
#include <linux/completion.h>
@@ -1059,14 +1058,8 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info)
else
aperture_remove_all_conflicting_devices(KBUILD_MODNAME);
- if (!gen2vm) {
+ if (!gen2vm)
pci_dev_put(pdev);
- } else if (IS_ENABLED(CONFIG_SYSFB)) {
- /* framebuffer is reallocated, clear screen_info to avoid misuse from kexec */
- screen_info.lfb_size = 0;
- screen_info.lfb_base = 0;
- screen_info.orig_video_isVGA = 0;
- }
return 0;
--
2.43.0
next prev parent reply other threads:[~2024-01-03 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 10:15 [PATCH 0/4] hyperv, sysfb: Do not use screen_info in drivers Thomas Zimmermann
2024-01-03 10:15 ` [PATCH 1/4] drm/hyperv: Remove firmware framebuffers with aperture helper Thomas Zimmermann
2024-01-08 9:26 ` Javier Martinez Canillas
2024-01-08 9:33 ` Helge Deller
2024-01-03 10:15 ` [PATCH 2/4] fbdev/hyperv_fb: Remove firmware framebuffers with aperture helpers Thomas Zimmermann
2024-01-08 9:27 ` Javier Martinez Canillas
2024-01-03 10:15 ` [PATCH 3/4] firmware/sysfb: Clear screen_info state after consuming it Thomas Zimmermann
2024-01-08 9:35 ` Javier Martinez Canillas
2024-01-03 10:15 ` Thomas Zimmermann [this message]
2024-01-08 9:36 ` [PATCH 4/4] fbdev/hyperv_fb: Do not clear global screen_info Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103102640.31751-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=decui@microsoft.com \
--cc=deller@gmx.de \
--cc=drawat.floss@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=haiyangz@microsoft.com \
--cc=javierm@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).