* [PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference
@ 2024-01-14 14:39 Andy Shevchenko
2024-01-15 17:21 ` Daniel Thompson
2024-01-25 13:23 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-01-14 14:39 UTC (permalink / raw)
To: Andy Shevchenko, dri-devel, linux-fbdev, linux-kernel
Cc: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Dan Carpenter
The "im" pins are optional. Add missing check in the hx8357_probe().
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/642e1230-3358-4006-a17f-3f297897ae74@moroto.mountain
Fixes: 7d84a63a39b7 ("backlight: hx8357: Convert to agnostic GPIO API")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/video/backlight/hx8357.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/backlight/hx8357.c
index d7298376cf74..bf18337ff0c2 100644
--- a/drivers/video/backlight/hx8357.c
+++ b/drivers/video/backlight/hx8357.c
@@ -609,11 +609,13 @@ static int hx8357_probe(struct spi_device *spi)
lcd->im_pins = devm_gpiod_get_array_optional(dev, "im", GPIOD_OUT_LOW);
if (IS_ERR(lcd->im_pins))
return dev_err_probe(dev, PTR_ERR(lcd->im_pins), "failed to request im GPIOs\n");
- if (lcd->im_pins->ndescs < HX8357_NUM_IM_PINS)
- return dev_err_probe(dev, -EINVAL, "not enough im GPIOs\n");
+ if (lcd->im_pins) {
+ if (lcd->im_pins->ndescs < HX8357_NUM_IM_PINS)
+ return dev_err_probe(dev, -EINVAL, "not enough im GPIOs\n");
- for (i = 0; i < HX8357_NUM_IM_PINS; i++)
- gpiod_set_consumer_name(lcd->im_pins->desc[i], "im_pins");
+ for (i = 0; i < HX8357_NUM_IM_PINS; i++)
+ gpiod_set_consumer_name(lcd->im_pins->desc[i], "im_pins");
+ }
lcdev = devm_lcd_device_register(&spi->dev, "mxsfb", &spi->dev, lcd,
&hx8357_ops);
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference
2024-01-14 14:39 [PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference Andy Shevchenko
@ 2024-01-15 17:21 ` Daniel Thompson
2024-01-25 13:23 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2024-01-15 17:21 UTC (permalink / raw)
To: Andy Shevchenko
Cc: dri-devel, linux-fbdev, linux-kernel, Lee Jones, Jingoo Han,
Helge Deller, Dan Carpenter
On Sun, Jan 14, 2024 at 04:39:21PM +0200, Andy Shevchenko wrote:
> The "im" pins are optional. Add missing check in the hx8357_probe().
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/642e1230-3358-4006-a17f-3f297897ae74@moroto.mountain
> Fixes: 7d84a63a39b7 ("backlight: hx8357: Convert to agnostic GPIO API")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: (subset) [PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference
2024-01-14 14:39 [PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference Andy Shevchenko
2024-01-15 17:21 ` Daniel Thompson
@ 2024-01-25 13:23 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2024-01-25 13:23 UTC (permalink / raw)
To: dri-devel, linux-fbdev, linux-kernel, Andy Shevchenko
Cc: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Dan Carpenter
On Sun, 14 Jan 2024 16:39:21 +0200, Andy Shevchenko wrote:
> The "im" pins are optional. Add missing check in the hx8357_probe().
>
>
Applied, thanks!
[1/1] backlight: hx8357: Fix potential NULL pointer dereference
commit: 3b75d271e161e22aff8171940a77510d2fb2ad6f
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-25 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-14 14:39 [PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference Andy Shevchenko
2024-01-15 17:21 ` Daniel Thompson
2024-01-25 13:23 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).