* [PATCH] backlight: ktd2801: make timing struct static
@ 2024-02-10 16:16 Duje Mihanović
2024-02-12 10:54 ` Daniel Thompson
2024-02-23 14:50 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Duje Mihanović @ 2024-02-10 16:16 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: Karel Balej, Linus Walleij, ~postmarketos/upstreaming,
phone-devel, dri-devel, linux-fbdev, linux-kernel,
kernel test robot, Duje Mihanović
The struct containing the KTD2801 timing can be made static as it's not
referenced outside the KTD2801 driver. Do this to prevent sparse
complaints.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402100625.M0RkJhMh-lkp@intel.com/
Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
drivers/video/backlight/ktd2801-backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/ktd2801-backlight.c b/drivers/video/backlight/ktd2801-backlight.c
index c020acff40f1..d295c2766025 100644
--- a/drivers/video/backlight/ktd2801-backlight.c
+++ b/drivers/video/backlight/ktd2801-backlight.c
@@ -13,7 +13,7 @@
#define KTD2801_MAX_BRIGHTNESS 255
/* These values have been extracted from Samsung's driver. */
-const struct expresswire_timing ktd2801_timing = {
+static const struct expresswire_timing ktd2801_timing = {
.poweroff_us = 2600,
.detect_delay_us = 150,
.detect_us = 270,
---
base-commit: 66c76c1cd984c14660453dfa2118014817924375
change-id: 20240210-ktd2801-static-e1c23d19600c
Best regards,
--
Duje Mihanović <duje.mihanovic@skole.hr>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] backlight: ktd2801: make timing struct static
2024-02-10 16:16 [PATCH] backlight: ktd2801: make timing struct static Duje Mihanović
@ 2024-02-12 10:54 ` Daniel Thompson
2024-02-23 14:50 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2024-02-12 10:54 UTC (permalink / raw)
To: Duje Mihanović
Cc: Lee Jones, Jingoo Han, Helge Deller, Karel Balej, Linus Walleij,
~postmarketos/upstreaming, phone-devel, dri-devel, linux-fbdev,
linux-kernel, kernel test robot
On Sat, Feb 10, 2024 at 05:16:17PM +0100, Duje Mihanović wrote:
> The struct containing the KTD2801 timing can be made static as it's not
> referenced outside the KTD2801 driver. Do this to prevent sparse
> complaints.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402100625.M0RkJhMh-lkp@intel.com/
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] backlight: ktd2801: make timing struct static
2024-02-10 16:16 [PATCH] backlight: ktd2801: make timing struct static Duje Mihanović
2024-02-12 10:54 ` Daniel Thompson
@ 2024-02-23 14:50 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2024-02-23 14:50 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Duje Mihanović
Cc: Karel Balej, Linus Walleij, ~postmarketos/upstreaming,
phone-devel, dri-devel, linux-fbdev, linux-kernel,
kernel test robot
On Sat, 10 Feb 2024 17:16:17 +0100, Duje Mihanović wrote:
> The struct containing the KTD2801 timing can be made static as it's not
> referenced outside the KTD2801 driver. Do this to prevent sparse
> complaints.
>
>
Applied, thanks!
[1/1] backlight: ktd2801: make timing struct static
commit: ed2ac75acf99d33444a5d440fcad4261ad6f0d5c
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-23 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-10 16:16 [PATCH] backlight: ktd2801: make timing struct static Duje Mihanović
2024-02-12 10:54 ` Daniel Thompson
2024-02-23 14:50 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).