From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 551F9127B73 for ; Thu, 15 Feb 2024 11:49:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707997749; cv=none; b=HUlfEwAO2J+XV5MhKL0bVXntWAuM4EGtT4YSONrCLLhfW7+/PKZnMjFPFqQwukmoXalB/b7/c/WKR5lEYe02VS9oxT0bsreJqwDYHWv2YhXllALY5wqz3TQQM2qMFN0QWHa7rPJ9jsRphGyYPDOBJ98QSOUtQxJoj3fm2vVrAkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707997749; c=relaxed/simple; bh=PMdqF4BxnLzSwd0JYe63JOfvhqT8FaZryFeHRQWW11s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zbl9mG2BKpHaeR/qPizwnS74dFZTvcXx0cZBxy04Okoyb0mZBqolpbvsgiqOshy0fMwcWqqIZ1xeut+Pyt8FbLWGfu/baDg4B/XtI0Ie1AzZ27m8Y79H/++woR9iDdrdXtT8KvwL1+9oWjgrQBw4UZq5fFBG2/TsBjfxgAVBXaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vKlbrH81; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vKlbrH81" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40fd72f7125so6482495e9.1 for ; Thu, 15 Feb 2024 03:49:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707997745; x=1708602545; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=PMdqF4BxnLzSwd0JYe63JOfvhqT8FaZryFeHRQWW11s=; b=vKlbrH81Q+fNYSZKaT93vsQazhllFw8PvlBaU03WUt0/++t49vHhlKe0JNGETVRW2s kpR7EZ8M+YM02cLkCmX87qdi/NqoewiErV7xTEOalX5BATkMLfrM0dEAZxv84Rq6JYNW JqPvkLSMR+re/+fyZT0LHags8GPH11gzWMPLz8UKwR/DG1MpTg7DItUfEaPQVEJR5U9a ihYZFgbAHaOyID1M1P1C+ahOICc1r2hTWtyFU4UxyN1vMPocW7vm374UjYtCOXwc4wab QQmFKHhUR1EJxyOOdakdtCLw66r6hysdLkxBne8cGhk4MuhUwL7o+lJY3PNlXBxmLqif D+HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707997745; x=1708602545; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PMdqF4BxnLzSwd0JYe63JOfvhqT8FaZryFeHRQWW11s=; b=EheR/ybhJClXiUrjyVd0ZI6+L6EzBAqWlOC8Dna8ubt93410+SoxJCkiLcqrrEMJ0a umsT3Me9kEK6ZbV+MPNHtMLBQbNlchMvVTMW6+YwJxHvdT2vl9DePyPH2v7mK8Sz6VL5 sZ8dMZS1osoE4FiSXA6nS0WCmJk+ZYIQ2gZswOlKpNoyVCs1g/s0MSfQEOkR3a3zMMAl Vc8JQNMfXpqQK0T7106+dbCGBV5tJXeOo3bXmCJNHBe0GizZ93eKHDBJ4AW3KHoSoRct uaNQFpuN995MV3bRJgasshgBFGLp6MBWR6B5X548k2Z9Yw19ie5Gf8xH/UwKQ6pYbsKD LS1w== X-Forwarded-Encrypted: i=1; AJvYcCXIwjNCpJP7J+GoSXiOK5DChwTZwtTVcQV4Qn30JrP56oAj6UBu4NWkEPf5Z7i08jqTUiQAAyxW3Q/NX36ZBfl57SANa3MbcOSdLt8= X-Gm-Message-State: AOJu0Yz9l0FAiirtDAXlFQ/OlHmOC7LsQrpVrESTFX5Ev1vZlEyuR88c dQVsQBIfib+fYcw7oNn2Y4yY/tSLRqhypZYgMmu2U638t6hCGrVwk6q19FMNDn0= X-Google-Smtp-Source: AGHT+IEPqfe0lQU32GGuFkM16RloqQWYNuLy7eiEqCzQNMdjhgJO3HI8g7e/KPfBuJeESwNfUgFUDQ== X-Received: by 2002:a05:600c:470b:b0:40e:a32c:988d with SMTP id v11-20020a05600c470b00b0040ea32c988dmr1202419wmo.4.1707997745749; Thu, 15 Feb 2024 03:49:05 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id n15-20020a7bcbcf000000b0041076fc2a61sm4778156wmi.5.2024.02.15.03.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 03:49:05 -0800 (PST) Date: Thu, 15 Feb 2024 11:49:03 +0000 From: Daniel Thompson To: Duje =?utf-8?Q?Mihanovi=C4=87?= Cc: Pavel Machek , Lee Jones , Linus Walleij , Arnd Bergmann , Flavio Suligoi , Hans de Goede , Jianhua Lu , "Matthew Wilcox (Oracle)" , Helge Deller , Jingoo Han , Karel Balej , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH 1/2] Revert "leds: Only descend into leds directory when CONFIG_NEW_LEDS is set" Message-ID: <20240215114903.GF9758@aspen.lan> References: <20240212-expresswire-deps-v1-0-685ad10cd693@skole.hr> <20240212-expresswire-deps-v1-1-685ad10cd693@skole.hr> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240212-expresswire-deps-v1-1-685ad10cd693@skole.hr> On Mon, Feb 12, 2024 at 09:03:25PM +0100, Duje Mihanović wrote: > This reverts commit b1ae40a5db6191c42e2e45d726407096f030ee08. > > The ExpressWire library introduced in 25ae5f5f4168 ("leds: Introduce > ExpressWire library") does not depend on NEW_LEDS, but without this > revert it would never get compiled if NEW_LEDS is not enabled. Revert > this commit to allow the library to be compiled. > > Link: https://lore.kernel.org/2cacd8dc-6150-4aa2-af9e-830a202fb0a8@app.fastmail.com > Suggested-by: Arnd Bergmann > Signed-off-by: Duje Mihanović Interesting that this could be a revert! Reviewed-by: Daniel Thompson Daniel.