From: Daniel Thompson <daniel.thompson@linaro.org>
To: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Luca Weiss <luca@z3ntu.xyz>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH RESEND 1/4] backlight: da9052: Fully initialize backlight_properties during probe
Date: Tue, 20 Feb 2024 15:35:24 +0000 [thread overview]
Message-ID: <20240220153532.76613-2-daniel.thompson@linaro.org> (raw)
In-Reply-To: <20240220153532.76613-1-daniel.thompson@linaro.org>
props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!
Fixes: 6ede3d832aaa ("backlight: add driver for DA9052/53 PMIC v1")
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
---
drivers/video/backlight/da9052_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/da9052_bl.c b/drivers/video/backlight/da9052_bl.c
index 1cdc8543310b4..b8ff7046510eb 100644
--- a/drivers/video/backlight/da9052_bl.c
+++ b/drivers/video/backlight/da9052_bl.c
@@ -117,6 +117,7 @@ static int da9052_backlight_probe(struct platform_device *pdev)
wleds->led_reg = platform_get_device_id(pdev)->driver_data;
wleds->state = DA9052_WLEDS_OFF;
+ memset(&props, 0, sizeof(struct backlight_properties));
props.type = BACKLIGHT_RAW;
props.max_brightness = DA9052_MAX_BRIGHTNESS;
--
2.43.0
next prev parent reply other threads:[~2024-02-20 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 15:35 [PATCH RESEND 0/4] Ensure all backlight drivers zero the properties structure Daniel Thompson
2024-02-20 15:35 ` Daniel Thompson [this message]
2024-02-20 15:35 ` [PATCH RESEND 2/4] backlight: lm3639: Fully initialize backlight_properties during probe Daniel Thompson
2024-02-20 15:35 ` [PATCH RESEND 3/4] backlight: lp8788: " Daniel Thompson
2024-02-20 15:35 ` [PATCH RESEND 4/4] backlight: mp3309c: " Daniel Thompson
2024-02-23 16:28 ` (subset) " Lee Jones
2024-02-20 16:48 ` [PATCH RESEND 0/4] Ensure all backlight drivers zero the properties structure Luca Weiss
2024-02-23 16:31 ` Lee Jones
2024-02-29 17:39 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220153532.76613-2-daniel.thompson@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).