[PATCH v3 0/9] fbdev: Clean up include dependencies in header

[PATCH v3 0/9] fbdev: Clean up include dependencies in header

[Thomas Zimmermann]

Remove unnecessary dependencies in the include statements of the
header file <linux/fb.h>. Several files throughout the kernel include
the fbdev header, so reducing dependencies positively affects other
subsystems as well. Also fix up corgi-lcd, nouveau and fbtft, which
need backlight.h in some of their source files.

v3:
	* include backlight.h in corgi-lcd (kernel test robot)
	* grammar fixes in commit messages
v2:
	* include backlight.h in fbtft (kernel test robot)

Thomas Zimmermann (9):
  backlight/corgi-lcd: Include <linux/backlight.h>
  drm/nouveau: Include <linux/backlight.h>
  staging/fbtft: Include <linux/backlight.h>
  fbdev: Do not include <linux/backlight.h> in header
  fbdev: Do not include <linux/fs.h> in header
  fbdev: Do not include <linux/notifier.h> in header
  fbdev: Do not include <linux/slab.h> in header
  fbdev: Clean up forward declarations in header file
  fbdev: Clean up include statements in header file

 drivers/gpu/drm/nouveau/dispnv50/disp.c |  1 +
 drivers/staging/fbtft/fb_ssd1351.c      |  2 ++
 drivers/video/backlight/corgi_lcd.c     |  1 +
 include/linux/fb.h                      | 24 +++++++++++++-----------
 4 files changed, 17 insertions(+), 11 deletions(-)

-- 
2.43.0

[PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h>

[Thomas Zimmermann]

Resolves the proxy include via <linux/fb.h>, which does not require the
backlight header.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/backlight/corgi_lcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c
index 0a57033ae31d1..dd765098ad989 100644
--- a/drivers/video/backlight/corgi_lcd.c
+++ b/drivers/video/backlight/corgi_lcd.c
@@ -11,6 +11,7 @@
  *	by Eric Miao <eric.miao@marvell.com>
  */
 
+#include <linux/backlight.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
-- 
2.43.0

Re: [PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h>

[Thomas Zimmermann]

cc'ing backlight maintainers

Am 19.02.24 um 10:37 schrieb Thomas Zimmermann:
> Resolves the proxy include via <linux/fb.h>, which does not require the
> backlight header.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/video/backlight/corgi_lcd.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c
> index 0a57033ae31d1..dd765098ad989 100644
> --- a/drivers/video/backlight/corgi_lcd.c
> +++ b/drivers/video/backlight/corgi_lcd.c
> @@ -11,6 +11,7 @@
>    *	by Eric Miao <eric.miao@marvell.com>
>    */
>   
> +#include <linux/backlight.h>
>   #include <linux/module.h>
>   #include <linux/kernel.h>
>   #include <linux/init.h>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: [PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h>

[Lee Jones]

On Wed, 21 Feb 2024, Thomas Zimmermann wrote:

> cc'ing backlight maintainers

I cannot review/accept patches like this.

Please submit a [RESEND].

> Am 19.02.24 um 10:37 schrieb Thomas Zimmermann:
> > Resolves the proxy include via <linux/fb.h>, which does not require the
> > backlight header.
> > 
> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> > ---
> >   drivers/video/backlight/corgi_lcd.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c
> > index 0a57033ae31d1..dd765098ad989 100644
> > --- a/drivers/video/backlight/corgi_lcd.c
> > +++ b/drivers/video/backlight/corgi_lcd.c
> > @@ -11,6 +11,7 @@
> >    *	by Eric Miao <eric.miao@marvell.com>
> >    */
> > +#include <linux/backlight.h>
> >   #include <linux/module.h>
> >   #include <linux/kernel.h>
> >   #include <linux/init.h>
> 
> -- 
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
> 

-- 
Lee Jones [李琼斯]

Re: [PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h>

[Jani Nikula]

On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote:
> On Wed, 21 Feb 2024, Thomas Zimmermann wrote:
>
>> cc'ing backlight maintainers
>
> I cannot review/accept patches like this.
>
> Please submit a [RESEND].

I bounced the original [1] to you. Please consider acking to merge the
one-line #include addition via fbdev so we don't have to respin the
series for no good reason.

BR,
Jani.


[1] https://lore.kernel.org/r/20240219093941.3684-2-tzimmermann@suse.de

>
>> Am 19.02.24 um 10:37 schrieb Thomas Zimmermann:
>> > Resolves the proxy include via <linux/fb.h>, which does not require the
>> > backlight header.
>> > 
>> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> > ---
>> >   drivers/video/backlight/corgi_lcd.c | 1 +
>> >   1 file changed, 1 insertion(+)
>> > 
>> > diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c
>> > index 0a57033ae31d1..dd765098ad989 100644
>> > --- a/drivers/video/backlight/corgi_lcd.c
>> > +++ b/drivers/video/backlight/corgi_lcd.c
>> > @@ -11,6 +11,7 @@
>> >    *	by Eric Miao <eric.miao@marvell.com>
>> >    */
>> > +#include <linux/backlight.h>
>> >   #include <linux/module.h>
>> >   #include <linux/kernel.h>
>> >   #include <linux/init.h>
>> 
>> -- 
>> --
>> Thomas Zimmermann
>> Graphics Driver Developer
>> SUSE Software Solutions Germany GmbH
>> Frankenstrasse 146, 90461 Nuernberg, Germany
>> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
>> HRB 36809 (AG Nuernberg)
>> 

-- 
Jani Nikula, Intel

Re: [PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h>

[Lee Jones]

On Mon, 26 Feb 2024, Jani Nikula wrote:

> On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote:
> > On Wed, 21 Feb 2024, Thomas Zimmermann wrote:
> >
> >> cc'ing backlight maintainers
> >
> > I cannot review/accept patches like this.
> >
> > Please submit a [RESEND].
> 
> I bounced the original [1] to you. Please consider acking to merge the
> one-line #include addition via fbdev so we don't have to respin the
> series for no good reason.

The "good reason" would be that it was not sent properly in the first
place.  My kernel.org mail is filtered by the recipients headers.  If
the original wasn't sent to me, bouncing won't work either.  I've since
reviewed the patch and seen the set on LORE.  This is non-optimal.
Please use get_maintainer.pl next time.

This time only, patch is:

Acked-by: Lee Jones <lee@kernel.org>

-- 
Lee Jones [李琼斯]

Re: [PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h>

[Thomas Zimmermann]

Hi

Am 26.02.24 um 13:33 schrieb Lee Jones:
> On Mon, 26 Feb 2024, Jani Nikula wrote:
>
>> On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote:
>>> On Wed, 21 Feb 2024, Thomas Zimmermann wrote:
>>>
>>>> cc'ing backlight maintainers
>>> I cannot review/accept patches like this.
>>>
>>> Please submit a [RESEND].
>> I bounced the original [1] to you. Please consider acking to merge the
>> one-line #include addition via fbdev so we don't have to respin the
>> series for no good reason.
> The "good reason" would be that it was not sent properly in the first
> place.  My kernel.org mail is filtered by the recipients headers.  If
> the original wasn't sent to me, bouncing won't work either.  I've since
> reviewed the patch and seen the set on LORE.  This is non-optimal.
> Please use get_maintainer.pl next time.
>
> This time only, patch is:
>
> Acked-by: Lee Jones <lee@kernel.org>

No problem, I'll send out another series. I just didn't get to do it.

Best regards
Thomas

>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: [PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h>

[Lee Jones]

On Mon, 26 Feb 2024, Thomas Zimmermann wrote:

> Hi
> 
> Am 26.02.24 um 13:33 schrieb Lee Jones:
> > On Mon, 26 Feb 2024, Jani Nikula wrote:
> > 
> > > On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote:
> > > > On Wed, 21 Feb 2024, Thomas Zimmermann wrote:
> > > > 
> > > > > cc'ing backlight maintainers
> > > > I cannot review/accept patches like this.
> > > > 
> > > > Please submit a [RESEND].
> > > I bounced the original [1] to you. Please consider acking to merge the
> > > one-line #include addition via fbdev so we don't have to respin the
> > > series for no good reason.
> > The "good reason" would be that it was not sent properly in the first
> > place.  My kernel.org mail is filtered by the recipients headers.  If
> > the original wasn't sent to me, bouncing won't work either.  I've since
> > reviewed the patch and seen the set on LORE.  This is non-optimal.
> > Please use get_maintainer.pl next time.
> > 
> > This time only, patch is:
> > 
> > Acked-by: Lee Jones <lee@kernel.org>
> 
> No problem, I'll send out another series. I just didn't get to do it.

No need to do that now on my behalf.  You have my Ack.

-- 
Lee Jones [李琼斯]

[PATCH v3 2/9] drm/nouveau: Include <linux/backlight.h>

[Thomas Zimmermann]

Resolves the proxy include via <linux/fb.h>, which does not require the
backlight header.

v3:
	* fix grammar in commit message

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Helge Deller <deller@gmx.de>
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 8d37a694b7724..0c3d88ad0b0ea 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -28,6 +28,7 @@
 #include "wndw.h"
 #include "handles.h"
 
+#include <linux/backlight.h>
 #include <linux/dma-mapping.h>
 #include <linux/hdmi.h>
 #include <linux/component.h>
-- 
2.43.0

[PATCH v3 3/9] staging/fbtft: Include <linux/backlight.h>

[Thomas Zimmermann]

Resolves the proxy include via <linux/fb.h>, which does not require the
backlight header.

v3:
	* fix grammar in commit message

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Helge Deller <deller@gmx.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/staging/fbtft/fb_ssd1351.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
index b8d55aa8c5c75..72172e870007e 100644
--- a/drivers/staging/fbtft/fb_ssd1351.c
+++ b/drivers/staging/fbtft/fb_ssd1351.c
@@ -1,4 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
+
+#include <linux/backlight.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
-- 
2.43.0

[PATCH v3 4/9] fbdev: Do not include <linux/backlight.h> in header

[Thomas Zimmermann]

Forward declare struct backlight_device and remove the include
statement.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Helge Deller <deller@gmx.de>
---
 include/linux/fb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 2ce2f5c2fca9a..7380d959c5d53 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -13,11 +13,11 @@
 #include <linux/workqueue.h>
 #include <linux/notifier.h>
 #include <linux/list.h>
-#include <linux/backlight.h>
 #include <linux/slab.h>
 
 #include <asm/fb.h>
 
+struct backlight_device;
 struct vm_area_struct;
 struct fb_info;
 struct device;
-- 
2.43.0

[PATCH v3 5/9] fbdev: Do not include <linux/fs.h> in header

[Thomas Zimmermann]

Forward declare struct inode and remove the include statement.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Helge Deller <deller@gmx.de>
---
 include/linux/fb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 7380d959c5d53..f269ba5202809 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -8,7 +8,6 @@
 
 #define FBIO_CURSOR            _IOWR('F', 0x08, struct fb_cursor_user)
 
-#include <linux/fs.h>
 #include <linux/init.h>
 #include <linux/workqueue.h>
 #include <linux/notifier.h>
@@ -22,6 +21,7 @@ struct vm_area_struct;
 struct fb_info;
 struct device;
 struct file;
+struct inode;
 struct videomode;
 struct device_node;
 
-- 
2.43.0

[PATCH v3 6/9] fbdev: Do not include <linux/notifier.h> in header

[Thomas Zimmermann]

Forward declare struct notifier_block and remove the include
statement.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Helge Deller <deller@gmx.de>
---
 include/linux/fb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index f269ba5202809..90f348f14a490 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -10,7 +10,6 @@
 
 #include <linux/init.h>
 #include <linux/workqueue.h>
-#include <linux/notifier.h>
 #include <linux/list.h>
 #include <linux/slab.h>
 
@@ -22,6 +21,7 @@ struct fb_info;
 struct device;
 struct file;
 struct inode;
+struct notifier_block;
 struct videomode;
 struct device_node;
 
-- 
2.43.0

[PATCH v3 7/9] fbdev: Do not include <linux/slab.h> in header

[Thomas Zimmermann]

Forward declare struct page and remove the include statement.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Helge Deller <deller@gmx.de>
---
 include/linux/fb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 90f348f14a490..42155898374b1 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -11,7 +11,6 @@
 #include <linux/init.h>
 #include <linux/workqueue.h>
 #include <linux/list.h>
-#include <linux/slab.h>
 
 #include <asm/fb.h>
 
@@ -22,6 +21,7 @@ struct device;
 struct file;
 struct inode;
 struct notifier_block;
+struct page;
 struct videomode;
 struct device_node;
 
-- 
2.43.0

[PATCH v3 8/9] fbdev: Clean up forward declarations in header file

[Thomas Zimmermann]

Add forward declarations for struct i2c_adapter and struct module, and
sort the list alphabetically.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Helge Deller <deller@gmx.de>
---
 include/linux/fb.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 42155898374b1..8f70ca727a30d 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -15,15 +15,17 @@
 #include <asm/fb.h>
 
 struct backlight_device;
-struct vm_area_struct;
-struct fb_info;
 struct device;
+struct device_node;
+struct fb_info;
 struct file;
+struct i2c_adapter;
 struct inode;
+struct module;
 struct notifier_block;
 struct page;
 struct videomode;
-struct device_node;
+struct vm_area_struct;
 
 /* Definitions below are used in the parsed monitor specs */
 #define FB_DPMS_ACTIVE_OFF	1
-- 
2.43.0

[PATCH v3 9/9] fbdev: Clean up include statements in header file

[Thomas Zimmermann]

Include mutex.h, printk.h and types.h, remove several unnecessary
include statements, and sort the list alphabetically.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Helge Deller <deller@gmx.de>
---
 include/linux/fb.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 8f70ca727a30d..708e6a177b1be 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -2,15 +2,15 @@
 #ifndef _LINUX_FB_H
 #define _LINUX_FB_H
 
-#include <linux/refcount.h>
-#include <linux/kgdb.h>
 #include <uapi/linux/fb.h>
 
 #define FBIO_CURSOR            _IOWR('F', 0x08, struct fb_cursor_user)
 
-#include <linux/init.h>
+#include <linux/mutex.h>
+#include <linux/printk.h>
+#include <linux/refcount.h>
+#include <linux/types.h>
 #include <linux/workqueue.h>
-#include <linux/list.h>
 
 #include <asm/fb.h>
 
-- 
2.43.0