From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Samuel Kayode <samkay014@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: rename function deGetTransparency()
Date: Tue, 5 Mar 2024 14:01:31 +0000 [thread overview]
Message-ID: <2024030505-luxurious-stung-4905@gregkh> (raw)
In-Reply-To: <ZdiyhAwNTPmbS3E0@Wayne>
On Fri, Feb 23, 2024 at 10:58:12AM -0400, Samuel Kayode wrote:
> Rename function deGetTransparency to de_get_transparency to fix
> checkpatch warning Avoid CamelCase.
>
> Signed-off-by: Samuel Kayode <samkay014@gmail.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 44b9e3fe3a41..ad9d8bd34e5a 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -284,7 +284,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
> return 0;
> }
>
> -static unsigned int deGetTransparency(struct lynx_accel *accel)
> +static unsigned int de_get_transparency(struct lynx_accel *accel)
What does "de_" here mean? Why did you keep it?
thanks,
greg k-h
prev parent reply other threads:[~2024-03-05 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 14:58 [PATCH] staging: sm750fb: rename function deGetTransparency() Samuel Kayode
2024-03-05 14:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024030505-luxurious-stung-4905@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=samkay014@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).