From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailrelay3-1.pub.mailoutpod2-cph3.one.com (mailrelay3-1.pub.mailoutpod2-cph3.one.com [46.30.211.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56AF44D599 for ; Wed, 13 Mar 2024 18:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.30.211.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710352900; cv=none; b=hJ/0UkcrvZ4Nq+SYl8AI58Qv88UMBM6Ixb/EkEK4/VjRnZ55Mux9HI8/L8y2PlwzxJt5DI0+NotUViwhMK5N+ASgsC6InwxEiaZYW6cfqu9ZBK9EHvJcF8Gditb5MRuhG+a0CEs+MpjofHEDA8dzqqtaVgORVZovsl1FXAvw1ws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710352900; c=relaxed/simple; bh=jbi1xGhYZSgZ7tq2Twfwbl4xBHjFmcYSMPhyLIA55yY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MFEyiveFN0ISb8Gvc33NSN+8ewdTKq/yujCCY+F0pX2YHY8f9hfV+gO1640pMkIcxuEwV97hy/F7rxpdXWwiCYCm3mTjK5jqBMbBWEINaQH9tCt8ZS8FFYS/8G16ZFRZQTLhqsnc9kkNoSUaFVoFr3ua1V+MfMlWbp9gEmNcjeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org; spf=none smtp.mailfrom=ravnborg.org; dkim=pass (2048-bit key) header.d=ravnborg.org header.i=@ravnborg.org header.b=jHylGeIv; dkim=permerror (0-bit key) header.d=ravnborg.org header.i=@ravnborg.org header.b=jhFCSZBv; arc=none smtp.client-ip=46.30.211.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ravnborg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ravnborg.org header.i=@ravnborg.org header.b="jHylGeIv"; dkim=permerror (0-bit key) header.d=ravnborg.org header.i=@ravnborg.org header.b="jhFCSZBv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=4rlXTwAFyuTm9avHYsJU7aqjVe3TlVfEuupS9PnmcmI=; b=jHylGeIvg1EqZg33U1cBL0AE4k6y3QBTOqlL04mnFXMsdMPrmRypJ2ydnguQJZ5cVsBi07MpCm49C vFXkQia1PI1i0AzXy3FCghpUTL52SGjWJroWEO6LGERZ+1XiYPiQzjo+P/LzO4p40QBCfQcXkco//P nWbAyMv3eeobvANOKOspRpgGWAST/3LgjAfDotbDxUwjXfzDlWn1eXNsiO0l58c9OXQwdzKk3eh6AX DnCwDDKaloa8RLGc4G5RvjyWDWwyIewhM8An36V5n7kndjcMqFSy0mes88nxcXqAkIuKQeY9c0MBBb NjRFiEQMbyCu2UgPSyz299220Ut/oPg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=4rlXTwAFyuTm9avHYsJU7aqjVe3TlVfEuupS9PnmcmI=; b=jhFCSZBvgXRzc76qH36LZTh0Bd7D1jojW03Yfd7T10v468cP+qf4PA2CnqUjWcTavOaKfYKH3IV3E VDj1ZZjDg== X-HalOne-ID: 927d3bf4-e163-11ee-8bee-119507214a65 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay3.pub.mailoutpod2-cph3.one.com (Halon) with ESMTPSA id 927d3bf4-e163-11ee-8bee-119507214a65; Wed, 13 Mar 2024 18:00:28 +0000 (UTC) Date: Wed, 13 Mar 2024 19:00:27 +0100 From: Sam Ravnborg To: Thomas Zimmermann Cc: lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, deller@gmx.de, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off Message-ID: <20240313180027.GB96726@ravnborg.org> References: <20240313154857.12949-1-tzimmermann@suse.de> <20240313154857.12949-4-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240313154857.12949-4-tzimmermann@suse.de> Hi Thomas, On Wed, Mar 13, 2024 at 04:45:02PM +0100, Thomas Zimmermann wrote: > The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for > any other value in fb_blank. But the field fb_blank in struct > backlight_properties is deprecated and should not be used any > longer. > > Replace the test for fb_blank in omap's backlight code with a > simple boolean parameter and push the test into the update_status > helper. Instead of reading fb_blank directly, decode the backlight > device's status with backlight_is_blank(). > > Signed-off-by: Thomas Zimmermann My biased opinion is that the approach in this patch is a little bit better: https://lore.kernel.org/lkml/20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org/ I never came around resending this series it seems. Sam