Re: [PATCH] backlight: lp8788: Drop support for platform data

[Lee Jones <lee@kernel.org>]

On Wed, 13 Mar 2024, Uwe Kleine-König wrote:

> Hello,
> 
> On Wed, Mar 13, 2024 at 01:48:27PM +0100, Uwe Kleine-König wrote:
> > diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c
> > index 31f97230ee50..f3a89677c31c 100644
> > --- a/drivers/video/backlight/lp8788_bl.c
> > +++ b/drivers/video/backlight/lp8788_bl.c
> > @@ -12,7 +12,6 @@
> >  #include <linux/mfd/lp8788.h>
> >  #include <linux/module.h>
> >  #include <linux/platform_device.h>
> > -#include <linux/pwm.h>
> >  #include <linux/slab.h>
> >  
> >  /* Register address */
> > @@ -31,149 +30,41 @@
> >  #define MAX_BRIGHTNESS			127
> >  #define DEFAULT_BL_NAME			"lcd-backlight"
> >  
> > -struct lp8788_bl_config {
> > -	enum lp8788_bl_ctrl_mode bl_mode;
> > -	enum lp8788_bl_dim_mode dim_mode;
> > -	enum lp8788_bl_full_scale_current full_scale;
> > -	enum lp8788_bl_ramp_step rise_time;
> > -	enum lp8788_bl_ramp_step fall_time;
> > -	enum pwm_polarity pwm_pol;
> > -};
> > -
> >  struct lp8788_bl {
> >  	struct lp8788 *lp;
> >  	struct backlight_device *bl_dev;
> > -	struct lp8788_backlight_platform_data *pdata;
> > -	enum lp8788_bl_ctrl_mode mode;
> >  	struct pwm_device *pwm;
> 
> Actually this pwm_device member should be dropped, too. I wonder why
> this even passes a W=1 build without a warning ...
> 
> @Lee: Feel free to fix this up while applying, or tell me if you prefer
> an incremental fixup or a complete v2.

Either of the last 2 options would be fine.

-- 
Lee Jones [李琼斯]