* [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus
@ 2024-03-22 8:29 Thomas Zimmermann
2024-03-22 10:43 ` Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Zimmermann @ 2024-03-22 8:29 UTC (permalink / raw)
To: nbowler, deller, javierm
Cc: linux-fbdev, dri-devel, linux-kernel, Thomas Zimmermann,
Daniel Vetter, Sam Ravnborg, Arnd Bergmann, Geert Uytterhoeven,
stable
Framebuffer I/O on the Sparc Sbus requires read/write helpers for
I/O memory. Select FB_IOMEM_FOPS accordingly.
Reported-by: Nick Bowler <nbowler@draconx.ca>
Closes: https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4faebfb@draconx.ca/
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Helge Deller <deller@gmx.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v6.8+
---
drivers/video/fbdev/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index a61b8260b8f36..edced74f0eeaf 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -494,6 +494,7 @@ config FB_SBUS_HELPERS
select FB_CFB_COPYAREA
select FB_CFB_FILLRECT
select FB_CFB_IMAGEBLIT
+ select FB_IOMEM_FOPS
config FB_BW2
bool "BWtwo support"
@@ -514,6 +515,7 @@ config FB_CG6
depends on (FB = y) && (SPARC && FB_SBUS)
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select FB_IOMEM_FOPS
help
This is the frame buffer device driver for the CGsix (GX, TurboGX)
frame buffer.
@@ -523,6 +525,7 @@ config FB_FFB
depends on FB_SBUS && SPARC64
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select FB_IOMEM_FOPS
help
This is the frame buffer device driver for the Creator, Creator3D,
and Elite3D graphics boards.
--
2.44.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus
2024-03-22 8:29 [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus Thomas Zimmermann
@ 2024-03-22 10:43 ` Javier Martinez Canillas
2024-03-23 6:17 ` Nick Bowler
2024-03-23 6:58 ` Sam Ravnborg
2024-03-25 20:37 ` Thomas Zimmermann
2 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2024-03-22 10:43 UTC (permalink / raw)
To: Thomas Zimmermann, nbowler, deller
Cc: linux-fbdev, dri-devel, linux-kernel, Thomas Zimmermann,
Daniel Vetter, Sam Ravnborg, Arnd Bergmann, Geert Uytterhoeven,
stable
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
> I/O memory. Select FB_IOMEM_FOPS accordingly.
>
> Reported-by: Nick Bowler <nbowler@draconx.ca>
> Closes: https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4faebfb@draconx.ca/
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v6.8+
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus
2024-03-22 10:43 ` Javier Martinez Canillas
@ 2024-03-23 6:17 ` Nick Bowler
0 siblings, 0 replies; 5+ messages in thread
From: Nick Bowler @ 2024-03-23 6:17 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: linux-fbdev, dri-devel, linux-kernel, Daniel Vetter, Sam Ravnborg,
Arnd Bergmann, Geert Uytterhoeven, stable,
Javier Martinez Canillas, deller
On 2024-03-22 06:43, Javier Martinez Canillas wrote:
> Thomas Zimmermann <tzimmermann@suse.de> writes:
>
>> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
>> I/O memory. Select FB_IOMEM_FOPS accordingly.
>>
>> Reported-by: Nick Bowler <nbowler@draconx.ca>
Applied on top of 6.8 and the build is successful.
Thanks,
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus
2024-03-22 8:29 [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus Thomas Zimmermann
2024-03-22 10:43 ` Javier Martinez Canillas
@ 2024-03-23 6:58 ` Sam Ravnborg
2024-03-25 20:37 ` Thomas Zimmermann
2 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2024-03-23 6:58 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: nbowler, deller, javierm, linux-fbdev, dri-devel, linux-kernel,
Daniel Vetter, Arnd Bergmann, Geert Uytterhoeven, stable
On Fri, Mar 22, 2024 at 09:29:46AM +0100, Thomas Zimmermann wrote:
> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
> I/O memory. Select FB_IOMEM_FOPS accordingly.
>
> Reported-by: Nick Bowler <nbowler@draconx.ca>
> Closes: https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4faebfb@draconx.ca/
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v6.8+
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus
2024-03-22 8:29 [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus Thomas Zimmermann
2024-03-22 10:43 ` Javier Martinez Canillas
2024-03-23 6:58 ` Sam Ravnborg
@ 2024-03-25 20:37 ` Thomas Zimmermann
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Zimmermann @ 2024-03-25 20:37 UTC (permalink / raw)
To: nbowler, deller, javierm
Cc: linux-fbdev, dri-devel, linux-kernel, Daniel Vetter, Sam Ravnborg,
Arnd Bergmann, Geert Uytterhoeven, stable
Merged into drm-misc-fixes.
Am 22.03.24 um 09:29 schrieb Thomas Zimmermann:
> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
> I/O memory. Select FB_IOMEM_FOPS accordingly.
>
> Reported-by: Nick Bowler <nbowler@draconx.ca>
> Closes: https://lore.kernel.org/lkml/5bc21364-41da-a339-676e-5bb0f4faebfb@draconx.ca/
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v6.8+
> ---
> drivers/video/fbdev/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index a61b8260b8f36..edced74f0eeaf 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -494,6 +494,7 @@ config FB_SBUS_HELPERS
> select FB_CFB_COPYAREA
> select FB_CFB_FILLRECT
> select FB_CFB_IMAGEBLIT
> + select FB_IOMEM_FOPS
>
> config FB_BW2
> bool "BWtwo support"
> @@ -514,6 +515,7 @@ config FB_CG6
> depends on (FB = y) && (SPARC && FB_SBUS)
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> + select FB_IOMEM_FOPS
> help
> This is the frame buffer device driver for the CGsix (GX, TurboGX)
> frame buffer.
> @@ -523,6 +525,7 @@ config FB_FFB
> depends on FB_SBUS && SPARC64
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> + select FB_IOMEM_FOPS
> help
> This is the frame buffer device driver for the Creator, Creator3D,
> and Elite3D graphics boards.
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-25 20:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-22 8:29 [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus Thomas Zimmermann
2024-03-22 10:43 ` Javier Martinez Canillas
2024-03-23 6:17 ` Nick Bowler
2024-03-23 6:58 ` Sam Ravnborg
2024-03-25 20:37 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).