From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4994610958; Thu, 2 May 2024 10:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714646154; cv=none; b=uhn0ATdvyZ28RCy/NCW9AubU8d1/KRLaxq8VMoC6NVZ9J7Dm9qgCE0qbPeWIiTxUJbpMLqNGt4JxHA6lK/0FxssCwYhOn5LD3X55Do/p+EAswZhXbJvMyfELO8YuCb0q5fhV1xevXxvzka9SNKHUV7AMQxzYyTZPh58SbnXiIEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714646154; c=relaxed/simple; bh=hK4ov6ylR1Ugfedc+gAwxkAdNe5nyfrosMJJf2M9fIY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u6j4VqjPGN4yYZ60TIFadf5N3DFJ4ulVV34jZbgJg1rVoNwcN6dSq6Qpy5jpqcyc5cPZYbOLqbWir6zEGdG9lwwcQ7fZgXDASJBsPjUvI8GYtFsPwlj5C3lTZNXqAfTVh+b6wB7ZdEtcu3OPChJiQGXGc0A3/qkIuNLAPYl5bUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cb3nqeBe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cb3nqeBe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A26A2C113CC; Thu, 2 May 2024 10:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714646153; bh=hK4ov6ylR1Ugfedc+gAwxkAdNe5nyfrosMJJf2M9fIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cb3nqeBeoHrI93ndU1+kejrXRKY7tNaPbqH2m3ypYfQt0F/4BTck0UMCuoIeHgYzO L+k6qhX8BRSRJz68WWe2Z0jNKC4qFtCKrGox2WZjYASmRLNimgWfseXSZL4ZOhwY+I KqmXiUErpbUR91g/quYjA+Fno7sL06owszJxxZJmmok9aqu4MqTFzFXb7Hnv51TK2p 5hElv0wJwHgqUJ2lm2zfjTotqInc38Tej28qhJrDZApzFJ2EFuMWhRnj6mFpPS+hhT h/iyHayqWeoFjCn5gzDi/BbSL7cmZcfetiU0OZj0y0XUvgNNCxZAs3fujWxvKFJONz Um35B46skZ3sw== Date: Thu, 2 May 2024 11:35:48 +0100 From: Lee Jones To: Shresth Prasad Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, deller@gmx.de, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, javier.carrasco.cruz@gmail.com, skhan@linuxfoundation.org, julia.lawall@inria.fr Subject: Re: [PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get Message-ID: <20240502103548.GU5338@google.com> References: <20240502063621.65687-2-shresthprasad7@gmail.com> <20240502093623.GJ5338@google.com> <20240502100822.GS5338@google.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240502100822.GS5338@google.com> On Thu, 02 May 2024, Lee Jones wrote: > On Thu, 02 May 2024, Shresth Prasad wrote: > > > On Thu, May 2, 2024 at 3:06 PM Lee Jones wrote: > > > > > > On Thu, 02 May 2024, Shresth Prasad wrote: > > > > > > > `dev->of_node` already has a reference to the device_node and calling > > > > of_node_get on it is unnecessary. All conresponding calls to > > > > of_node_put are also removed. > > > > > > > > Reviewed-by: Daniel Thompson > > > > Signed-off-by: Shresth Prasad > > > > --- > > > > Changes in v3: > > > > - Remove unnecessary braces > > > > > > > > drivers/video/backlight/sky81452-backlight.c | 8 ++------ > > > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > > > No idea what you're talking about. > > > > > > This patch/version doesn't exist in either my inbox or LORE: > > > > > > https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22 > > > > > > -- > > > Lee Jones [李琼斯] > > > > I'm not sure what you mean. > > The patches show up just fine: > > https://lore.kernel.org/all/?q=backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get > > > > If you mean that the first version doesn't show up, it's because the > > commit message > > was changed to better reflect changes. > > Those are v2 > > You replied to a non-existent v3 which started a new thread. Something funky is going on. Your pokey emails are coming through disconnected from the patches which is causing confusion. The best thing going forward is to submit [RESEND]s instead of contentless pokes. Please submit a [RESEND] for v3 and we can start again. -- Lee Jones [李琼斯]