* [PATCH v2] backlight: l4f00242t03: Add check for spi_setup
@ 2024-07-05 9:28 Chen Ni
2024-07-05 10:26 ` Daniel Thompson
2024-07-25 7:39 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2024-07-05 9:28 UTC (permalink / raw)
To: lee, daniel.thompson, jingoohan1, deller
Cc: dri-devel, linux-fbdev, linux-kernel, Chen Ni
Add check for the return value of spi_setup() and return the error
if it fails in order to catch the error.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
Changelog:
v1 -> v2:
1. Use dev_err_probe() to match other error paths
---
drivers/video/backlight/l4f00242t03.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index dd0874f8c7ff..4175a4603071 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -166,6 +166,7 @@ static const struct lcd_ops l4f_ops = {
static int l4f00242t03_probe(struct spi_device *spi)
{
struct l4f00242t03_priv *priv;
+ int ret;
priv = devm_kzalloc(&spi->dev, sizeof(struct l4f00242t03_priv),
GFP_KERNEL);
@@ -174,7 +175,9 @@ static int l4f00242t03_probe(struct spi_device *spi)
spi_set_drvdata(spi, priv);
spi->bits_per_word = 9;
- spi_setup(spi);
+ ret = spi_setup(spi);
+ if (ret < 0)
+ return dev_err_probe(&spi->dev, ret, "Unable to setup spi.\n");
priv->spi = spi;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] backlight: l4f00242t03: Add check for spi_setup
2024-07-05 9:28 [PATCH v2] backlight: l4f00242t03: Add check for spi_setup Chen Ni
@ 2024-07-05 10:26 ` Daniel Thompson
2024-07-25 7:39 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2024-07-05 10:26 UTC (permalink / raw)
To: Chen Ni; +Cc: lee, jingoohan1, deller, dri-devel, linux-fbdev, linux-kernel
On Fri, Jul 05, 2024 at 05:28:00PM +0800, Chen Ni wrote:
> Add check for the return value of spi_setup() and return the error
> if it fails in order to catch the error.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH v2] backlight: l4f00242t03: Add check for spi_setup
2024-07-05 9:28 [PATCH v2] backlight: l4f00242t03: Add check for spi_setup Chen Ni
2024-07-05 10:26 ` Daniel Thompson
@ 2024-07-25 7:39 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2024-07-25 7:39 UTC (permalink / raw)
To: lee, daniel.thompson, jingoohan1, deller, Chen Ni
Cc: dri-devel, linux-fbdev, linux-kernel
On Fri, 05 Jul 2024 17:28:00 +0800, Chen Ni wrote:
> Add check for the return value of spi_setup() and return the error
> if it fails in order to catch the error.
>
>
Applied, thanks!
[1/1] backlight: l4f00242t03: Add check for spi_setup
commit: cec01c3b62f11efabc8c92f91472575651c593a9
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-25 7:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-05 9:28 [PATCH v2] backlight: l4f00242t03: Add check for spi_setup Chen Ni
2024-07-05 10:26 ` Daniel Thompson
2024-07-25 7:39 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).