Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 02 Jul 2024 17:34:04 +0000
Guillaume Stols <gstols@baylibre.com> wrote:

> This series adds the following improvements over the current AD7606's
> driver implementation:
> 
> - Fix wrong usage of gpio array
> - Fix standby that was documented as ACTIVE_LOW but handled in the
>   driver as if it was ACTIVE_HIGH
> - Improve dt-bindings documentation
> - Switch mutex lock to scoped guard
> 
> Signed-off-by: Guillaume Stols <gstols@baylibre.com>
Given issues I'm having locally with b4 I applied these but added tags by hand.
Tweaked last patch description to mention guard() rather than scoped_guard()
to reflect changes in v3.

Thanks,

Jonathan

> ---
> Changes in v3:
> - Remove the two first patches that were already picked up.
> - Add styling corrections.
> - [Patch 6/8] Improve commit message.
> - [Patch 8/8] Replace every scoped_guard by simple guard.
> - Link to v2: https://lore.kernel.org/r/20240628-cleanup-ad7606-v2-0-96e02f90256d@baylibre.com
> 
> Changes in v2:
> - Change scoped guard to guard(mutex)(&st->lock). This was tested with
>   Rob's bot condition, and seems not to generate warning anymore.
> - Reorder the commits for avoiding bisection issues and respect commit
>   priority rules.
> - Add vdrive-supply to required properties.
> - Separate cosmetic changes from content ones in dt-binding
>   descriptions.
> - Move maxItems changes (and plural in descriptions) to the commit that
>   adds conditions.
> - Link to v1: https://lore.kernel.org/r/20240618-cleanup-ad7606-v1-0-f1854d5c779d@baylibre.com
> 
> ---
> Guillaume Stols (8):
>       dt-bindings: iio: adc: adi,ad7606: normalize textwidth
>       dt-bindings: iio: adc: adi,ad7606: improve descriptions
>       dt-bindings: iio: adc: adi,ad7606: add supply properties
>       dt-bindings: iio: adc: adi,ad7606: fix example
>       dt-bindings: iio: adc: adi,ad7606: add conditions
>       iio: adc: ad7606: fix oversampling gpio array
>       iio: adc: ad7606: fix standby gpio state to match the documentation
>       iio: adc: ad7606: switch mutexes to scoped_guard
> 
>  .../devicetree/bindings/iio/adc/adi,ad7606.yaml    | 123 ++++++++++++++++-----
>  drivers/iio/adc/ad7606.c                           |  47 ++++----
>  drivers/iio/adc/ad7606_spi.c                       |   5 +-
>  3 files changed, 115 insertions(+), 60 deletions(-)
> ---
> base-commit: 340fa834ae229a952db04a57ed13fd5d35d75818
> change-id: 20240416-cleanup-ad7606-161e2ed9818b
> 
> Best regards,