From: Greg KH <gregkh@linuxfoundation.org>
To: Riyan Dhiman <riyandhiman14@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call
Date: Tue, 23 Jul 2024 15:06:03 +0200 [thread overview]
Message-ID: <2024072320-trimness-scribe-8055@gregkh> (raw)
In-Reply-To: <CAAjz0QbtK=c98QP5t76_=_Xrg4+3bHksXR=_QJfz0W0f_zZ=vA@mail.gmail.com>
On Tue, Jul 23, 2024 at 06:28:19PM +0530, Riyan Dhiman wrote:
> Hi,
>
> Thank you for your feedback on my patch submission.
> I have reviewed the mailing list traffic and noted that the last patch
> addressing the same coding style issue was submitted in April. Given this
> timeframe, I believed it was appropriate to submit my patch to contribute
> to the resolution of the ongoing issue.
> As this is my first contribution to the Linux kernel, I want to ensure that
> my submission aligns with the requirements. I would greatly appreciate your
> guidance on how to improve my patch and avoid duplicating previous efforts.
The issue is that the checkpatch warning for too many () characters is
just not right, and shouldn't be applied for staging fixes, sorry. The
code is fine as-is.
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-23 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 6:03 [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call Riyan Dhiman
2024-07-23 7:43 ` Greg KH
[not found] ` <CAAjz0QbtK=c98QP5t76_=_Xrg4+3bHksXR=_QJfz0W0f_zZ=vA@mail.gmail.com>
2024-07-23 13:06 ` Greg KH [this message]
[not found] ` <CAAjz0QZpJWBHxn131xaeGHoUyLA3rf4JGRW9Vaw6ko9+zEz8hA@mail.gmail.com>
2024-07-24 13:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024072320-trimness-scribe-8055@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=riyandhiman14@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).