From: Greg KH <gregkh@linuxfoundation.org>
To: Riyan Dhiman <riyandhiman14@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call
Date: Wed, 24 Jul 2024 15:55:24 +0200 [thread overview]
Message-ID: <2024072441-evasion-armored-42f1@gregkh> (raw)
In-Reply-To: <CAAjz0QZpJWBHxn131xaeGHoUyLA3rf4JGRW9Vaw6ko9+zEz8hA@mail.gmail.com>
On Wed, Jul 24, 2024 at 06:22:55PM +0530, Riyan Dhiman wrote:
> Hi,
>
> Thank you for your feedback on my patch submission.
> I understand that the fix provided by my patch is not needed. As this is my
> first contribution to the Linux kernel, I am eager to learn and make
> valuable contributions.
> To ensure my future submissions are more aligned with the needs, I would
> like to know if it would be helpful for me to focus on the following types
> of fixes:
>
> - CHECK: usleep_range is preferred over udelay; see
> Documentation/timers/timers-howto.rst
That's very hard to fix without access to the device and the knowledge
of what needs to happen. See the archives for where people have tried
to do this and the responses they got.
> - WARNING: Unnecessary ftrace-like logging - prefer using ftrace
That's good to clean up, try that and see!
thanks,
g
reg k-h
prev parent reply other threads:[~2024-07-24 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 6:03 [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call Riyan Dhiman
2024-07-23 7:43 ` Greg KH
[not found] ` <CAAjz0QbtK=c98QP5t76_=_Xrg4+3bHksXR=_QJfz0W0f_zZ=vA@mail.gmail.com>
2024-07-23 13:06 ` Greg KH
[not found] ` <CAAjz0QZpJWBHxn131xaeGHoUyLA3rf4JGRW9Vaw6ko9+zEz8hA@mail.gmail.com>
2024-07-24 13:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024072441-evasion-armored-42f1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=riyandhiman14@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).