From: Greg KH <gregkh@linuxfoundation.org>
To: Sakirnth Nagarasa <sakirnth@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
~lkcamp/patches@lists.sr.ht, helen.koike@collabora.com
Subject: Re: [PATCH] staging: fbtft: Remove trailing semicolon in macro.
Date: Tue, 30 Jul 2024 09:17:38 +0200 [thread overview]
Message-ID: <2024073026-clubhouse-vividness-600d@gregkh> (raw)
In-Reply-To: <20240730071455.37494-1-sakirnth@gmail.com>
On Tue, Jul 30, 2024 at 07:14:55AM +0000, Sakirnth Nagarasa wrote:
> Fix checkpath warning: "WARNING: macros should not use a trailing semicolon
> in fbtft.h:356.
>
> Signed-off-by: Sakirnth Nagarasa <sakirnth@gmail.com>
>
> ---
>
> Hello, this is my first patch to the kernel.
> ---
> drivers/staging/fbtft/fbtft.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index f86ed9d47..45dfc92b8 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -365,7 +365,7 @@ MODULE_DEVICE_TABLE(spi, spi_ids); \
> \
> FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids) \
> \
> -module_spi_driver(fbtft_driver_spi_driver);
> +module_spi_driver(fbtft_driver_spi_driver)
checkpatch is wrong here, the ';' is correct.
thanks,
greg k-h
prev parent reply other threads:[~2024-07-30 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 7:14 [PATCH] staging: fbtft: Remove trailing semicolon in macro Sakirnth Nagarasa
2024-07-30 7:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024073026-clubhouse-vividness-600d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=helen.koike@collabora.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sakirnth@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox