* [PATCH] backlight: pwm_bl: print errno for probe errors
@ 2024-08-01 9:12 Martin Kepplinger-Novaković
2024-08-01 9:26 ` Uwe Kleine-König
2024-08-01 12:31 ` Lee Jones
0 siblings, 2 replies; 6+ messages in thread
From: Martin Kepplinger-Novaković @ 2024-08-01 9:12 UTC (permalink / raw)
To: ukleinek, lee, daniel.thompson, jingoohan1
Cc: linux-pwm, dri-devel, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]
This makes debugging often easier.
Signed-off-by: Martin Kepplinger-Novaković <martin.kepplinger-novakovic@ginzinger.com>
---
drivers/video/backlight/pwm_bl.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index f1005bd0c41e3..cc7e7af71891f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
GPIOD_ASIS);
if (IS_ERR(pb->enable_gpio)) {
ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->enable_gpio),
- "failed to acquire enable GPIO\n");
+ "failed to acquire enable GPIO: %ld\n",
+ PTR_ERR(pb->enable_gpio));
goto err_alloc;
}
@@ -513,7 +514,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
pb->power_supply = NULL;
} else {
dev_err_probe(&pdev->dev, ret,
- "failed to acquire power regulator\n");
+ "failed to acquire power regulator: %d\n",
+ ret);
goto err_alloc;
}
}
@@ -521,7 +523,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
pb->pwm = devm_pwm_get(&pdev->dev, NULL);
if (IS_ERR(pb->pwm)) {
ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->pwm),
- "unable to request PWM\n");
+ "unable to request PWM: %ld\n",
+ PTR_ERR(pb->pwm));
goto err_alloc;
}
--
2.39.2
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 7522 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] backlight: pwm_bl: print errno for probe errors
2024-08-01 9:12 [PATCH] backlight: pwm_bl: print errno for probe errors Martin Kepplinger-Novaković
@ 2024-08-01 9:26 ` Uwe Kleine-König
2024-08-01 9:52 ` Kepplinger-Novakovic Martin
2024-08-01 12:31 ` Lee Jones
1 sibling, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2024-08-01 9:26 UTC (permalink / raw)
To: Martin Kepplinger-Novaković
Cc: lee, daniel.thompson, jingoohan1, linux-pwm, dri-devel,
linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
Hello Martin,
On Thu, Aug 01, 2024 at 11:12:55AM +0200, Martin Kepplinger-Novaković wrote:
> This makes debugging often easier.
>
> Signed-off-by: Martin Kepplinger-Novaković <martin.kepplinger-novakovic@ginzinger.com>
> ---
> drivers/video/backlight/pwm_bl.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index f1005bd0c41e3..cc7e7af71891f 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> GPIOD_ASIS);
> if (IS_ERR(pb->enable_gpio)) {
> ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->enable_gpio),
> - "failed to acquire enable GPIO\n");
> + "failed to acquire enable GPIO: %ld\n",
> + PTR_ERR(pb->enable_gpio));
AFAIK dev_err_probe already emits the error code passed as 2nd
parameter. So I wonder about this patch's benefit.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] backlight: pwm_bl: print errno for probe errors
2024-08-01 9:26 ` Uwe Kleine-König
@ 2024-08-01 9:52 ` Kepplinger-Novakovic Martin
2024-08-01 10:09 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Kepplinger-Novakovic Martin @ 2024-08-01 9:52 UTC (permalink / raw)
To: u.kleine-koenig@baylibre.com
Cc: daniel.thompson@linaro.org, lee@kernel.org,
linux-pwm@vger.kernel.org, jingoohan1@gmail.com,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]
Am Donnerstag, dem 01.08.2024 um 11:26 +0200 schrieb Uwe Kleine-König:
> Hello Martin,
>
> On Thu, Aug 01, 2024 at 11:12:55AM +0200, Martin Kepplinger-Novaković
> wrote:
> > This makes debugging often easier.
> >
> > Signed-off-by: Martin Kepplinger-Novaković
> > <martin.kepplinger-novakovic@ginzinger.com>
> > ---
> > drivers/video/backlight/pwm_bl.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c
> > b/drivers/video/backlight/pwm_bl.c
> > index f1005bd0c41e3..cc7e7af71891f 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct
> > platform_device *pdev)
> > GPIOD_ASIS);
> > if (IS_ERR(pb->enable_gpio)) {
> > ret = dev_err_probe(&pdev->dev, PTR_ERR(pb-
> > >enable_gpio),
> > - "failed to acquire enable
> > GPIO\n");
> > + "failed to acquire enable GPIO:
> > %ld\n",
> > + PTR_ERR(pb->enable_gpio));
>
> AFAIK dev_err_probe already emits the error code passed as 2nd
> parameter. So I wonder about this patch's benefit.
>
It does. Other messages only take the deferred_probe_reason without the
error code. It's actually fine if users properly enable debugging after
seeing an error and then this change is not needed :)
thanks,
martin
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 7522 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] backlight: pwm_bl: print errno for probe errors
2024-08-01 9:52 ` Kepplinger-Novakovic Martin
@ 2024-08-01 10:09 ` Uwe Kleine-König
2024-08-01 10:12 ` Kepplinger-Novakovic Martin
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2024-08-01 10:09 UTC (permalink / raw)
To: Kepplinger-Novakovic Martin
Cc: daniel.thompson@linaro.org, lee@kernel.org,
linux-pwm@vger.kernel.org, jingoohan1@gmail.com,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]
Hello Martin,
On Thu, Aug 01, 2024 at 09:52:01AM +0000, Kepplinger-Novakovic Martin wrote:
> Am Donnerstag, dem 01.08.2024 um 11:26 +0200 schrieb Uwe Kleine-König:
> > On Thu, Aug 01, 2024 at 11:12:55AM +0200, Martin Kepplinger-Novaković
> > wrote:
> > > diff --git a/drivers/video/backlight/pwm_bl.c
> > > b/drivers/video/backlight/pwm_bl.c
> > > index f1005bd0c41e3..cc7e7af71891f 100644
> > > --- a/drivers/video/backlight/pwm_bl.c
> > > +++ b/drivers/video/backlight/pwm_bl.c
> > > @@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct
> > > platform_device *pdev)
> > > GPIOD_ASIS);
> > > if (IS_ERR(pb->enable_gpio)) {
> > > ret = dev_err_probe(&pdev->dev, PTR_ERR(pb-
> > > >enable_gpio),
> > > - "failed to acquire enable
> > > GPIO\n");
> > > + "failed to acquire enable GPIO:
> > > %ld\n",
> > > + PTR_ERR(pb->enable_gpio));
> >
> > AFAIK dev_err_probe already emits the error code passed as 2nd
> > parameter. So I wonder about this patch's benefit.
> >
>
> It does. Other messages only take the deferred_probe_reason without the
> error code. It's actually fine if users properly enable debugging after
> seeing an error and then this change is not needed :)
I'm unsure what you intend to say here. Do you agree that this patch
doesn't need to be applied as it doesn't add any information to the
emitted messages? Or do you think there is a value because "users don't
need to enable debugging" then. In the latter case I don't see where
users would see "failed to acquire enable GPIO" before, but not the
value of the error code.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] backlight: pwm_bl: print errno for probe errors
2024-08-01 10:09 ` Uwe Kleine-König
@ 2024-08-01 10:12 ` Kepplinger-Novakovic Martin
0 siblings, 0 replies; 6+ messages in thread
From: Kepplinger-Novakovic Martin @ 2024-08-01 10:12 UTC (permalink / raw)
To: u.kleine-koenig@baylibre.com
Cc: daniel.thompson@linaro.org, lee@kernel.org,
linux-pwm@vger.kernel.org, jingoohan1@gmail.com,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]
Am Donnerstag, dem 01.08.2024 um 12:09 +0200 schrieb Uwe Kleine-König:
> Hello Martin,
>
> On Thu, Aug 01, 2024 at 09:52:01AM +0000, Kepplinger-Novakovic Martin
> wrote:
> > Am Donnerstag, dem 01.08.2024 um 11:26 +0200 schrieb Uwe Kleine-
> > König:
> > > On Thu, Aug 01, 2024 at 11:12:55AM +0200, Martin Kepplinger-
> > > Novaković
> > > wrote:
> > > > diff --git a/drivers/video/backlight/pwm_bl.c
> > > > b/drivers/video/backlight/pwm_bl.c
> > > > index f1005bd0c41e3..cc7e7af71891f 100644
> > > > --- a/drivers/video/backlight/pwm_bl.c
> > > > +++ b/drivers/video/backlight/pwm_bl.c
> > > > @@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct
> > > > platform_device *pdev)
> > > > GPIOD_ASIS);
> > > > if (IS_ERR(pb->enable_gpio)) {
> > > > ret = dev_err_probe(&pdev->dev, PTR_ERR(pb-
> > > > > enable_gpio),
> > > > - "failed to acquire enable
> > > > GPIO\n");
> > > > + "failed to acquire enable
> > > > GPIO:
> > > > %ld\n",
> > > > + PTR_ERR(pb->enable_gpio));
> > >
> > > AFAIK dev_err_probe already emits the error code passed as 2nd
> > > parameter. So I wonder about this patch's benefit.
> > >
> >
> > It does. Other messages only take the deferred_probe_reason without
> > the
> > error code. It's actually fine if users properly enable debugging
> > after
> > seeing an error and then this change is not needed :)
>
> I'm unsure what you intend to say here. Do you agree that this patch
> doesn't need to be applied as it doesn't add any information to the
> emitted messages? Or do you think there is a value because "users
> don't
> need to enable debugging" then. In the latter case I don't see where
> users would see "failed to acquire enable GPIO" before, but not the
> value of the error code.
>
hi Uwe, sorry, I agree that this patch doesn't add any information. I
think it can be expected to look at debug when drivers don't probe.
thanks,
martin
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 7522 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] backlight: pwm_bl: print errno for probe errors
2024-08-01 9:12 [PATCH] backlight: pwm_bl: print errno for probe errors Martin Kepplinger-Novaković
2024-08-01 9:26 ` Uwe Kleine-König
@ 2024-08-01 12:31 ` Lee Jones
1 sibling, 0 replies; 6+ messages in thread
From: Lee Jones @ 2024-08-01 12:31 UTC (permalink / raw)
To: Martin Kepplinger-Novaković
Cc: ukleinek, daniel.thompson, jingoohan1, linux-pwm, dri-devel,
linux-fbdev, linux-kernel
On Thu, 01 Aug 2024, Martin Kepplinger-Novaković wrote:
> This makes debugging often easier.
>
> Signed-off-by: Martin Kepplinger-Novaković <martin.kepplinger-novakovic@ginzinger.com>
> ---
> drivers/video/backlight/pwm_bl.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Please refrain from signing your mails like this. It means that some of
us have to physically click a pop-up box as we are parsing our inboxes.
I'm deleting all mails in this thread.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-01 12:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 9:12 [PATCH] backlight: pwm_bl: print errno for probe errors Martin Kepplinger-Novaković
2024-08-01 9:26 ` Uwe Kleine-König
2024-08-01 9:52 ` Kepplinger-Novakovic Martin
2024-08-01 10:09 ` Uwe Kleine-König
2024-08-01 10:12 ` Kepplinger-Novakovic Martin
2024-08-01 12:31 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).