From: Riyan Dhiman <riyandhiman14@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Riyan Dhiman <riyandhiman14@gmail.com>
Subject: [PATCH] staging: vme_user: vme_bridge.h: Document mutex in vme_dma_resource structure
Date: Sat, 3 Aug 2024 05:48:14 +0530 [thread overview]
Message-ID: <20240803001814.7752-1-riyandhiman14@gmail.com> (raw)
Adhere to Linux kernel coding style
Reported by checkpatch:
CHECK: mutex definition without comment
Proof for comment:
1. The mutex is used to protect access to the 'running' list
(line 1798 tsi148_dma_list_exec function)
mutex_lock(&ctrlrl->mtx);
if (!list_empty(&ctrlr->running)) {
mutex_unlock(&ctrlr->mtx);
return -EBUSY;
}
This prevents race conditions when multiple threads attempt to start DMA
operations simultaneously.
2. It's also used when removing DMA list from running list:
(line 1862 tsi148_dma_list_exec function)
mutex_lock(&ctrlr->mtx);
list_del(&list->list);
mutex_unlock(&ctrlr->mtx);
Ensuring thread-safe modification of the controller's state.
Without this mutex, concurrent access to the DMA controller's state could
lead to data corruption or inconsistant state.
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
---
drivers/staging/vme_user/vme_bridge.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
index 9bdc41bb6602..bb3750b40eb1 100644
--- a/drivers/staging/vme_user/vme_bridge.h
+++ b/drivers/staging/vme_user/vme_bridge.h
@@ -61,6 +61,7 @@ struct vme_dma_list {
struct vme_dma_resource {
struct list_head list;
struct vme_bridge *parent;
+ /* Mutex to protect DMA controller resources and ensure thread-safe operations */
struct mutex mtx;
int locked;
int number;
--
2.39.2
next reply other threads:[~2024-08-03 0:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-03 0:18 Riyan Dhiman [this message]
2024-08-03 4:23 ` [PATCH] staging: vme_user: vme_bridge.h: Document mutex in vme_dma_resource structure Dan Carpenter
[not found] ` <CAAjz0QY9jDUx-URQTtdW3kO2mkfV4dhUsJhB9-k12SEt++Gp8g@mail.gmail.com>
2024-08-14 9:30 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240803001814.7752-1-riyandhiman14@gmail.com \
--to=riyandhiman14@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox