From: Thomas Zimmermann <tzimmermann@suse.de>
To: lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com,
deller@gmx.de, bonbons@linux-vserver.org, jikos@kernel.org,
bentiss@kernel.org, shc_work@mail.ru, s.hauer@pengutronix.de,
kernel@pengutronix.de, shawnguo@kernel.org, festevam@gmail.com
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 01/28] backlight: lcd: Rearrange code in fb_notifier_callback()
Date: Tue, 20 Aug 2024 11:22:39 +0200 [thread overview]
Message-ID: <20240820093452.68270-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20240820093452.68270-1-tzimmermann@suse.de>
First aqcuire the ops_lock and do al tests while holing it. Rearranges
the code in lcd's fb_notifier_callback() to resemble the callback in
the backlight module. This will simplify later changes to these tests.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/backlight/lcd.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c
index ceec90ca758b..0cd0fa1b24f9 100644
--- a/drivers/video/backlight/lcd.c
+++ b/drivers/video/backlight/lcd.c
@@ -29,21 +29,25 @@ static int fb_notifier_callback(struct notifier_block *self,
{
struct lcd_device *ld;
struct fb_event *evdata = data;
+ struct fb_info *info = evdata->info;
ld = container_of(self, struct lcd_device, fb_notif);
+ mutex_lock(&ld->ops_lock);
+
if (!ld->ops)
- return 0;
+ goto out;
+ if (ld->ops->check_fb && !ld->ops->check_fb(ld, evdata->info))
+ goto out;
- mutex_lock(&ld->ops_lock);
- if (!ld->ops->check_fb || ld->ops->check_fb(ld, evdata->info)) {
- if (event == FB_EVENT_BLANK) {
- if (ld->ops->set_power)
- ld->ops->set_power(ld, *(int *)evdata->data);
- } else {
- if (ld->ops->set_mode)
- ld->ops->set_mode(ld, evdata->data);
- }
+ if (event == FB_EVENT_BLANK) {
+ if (ld->ops->set_power)
+ ld->ops->set_power(ld, *(int *)evdata->data);
+ } else {
+ if (ld->ops->set_mode)
+ ld->ops->set_mode(ld, evdata->data);
}
+
+out:
mutex_unlock(&ld->ops_lock);
return 0;
}
--
2.46.0
next prev parent reply other threads:[~2024-08-20 9:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 9:22 [PATCH 00/28] backlight: lcd: Remove fbdev dependencies Thomas Zimmermann
2024-08-20 9:22 ` Thomas Zimmermann [this message]
2024-09-03 14:54 ` [PATCH 01/28] backlight: lcd: Rearrange code in fb_notifier_callback() Daniel Thompson
2024-08-20 9:22 ` [PATCH 02/28] backlight: lcd: Test against struct fb_info.lcd_dev Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 03/28] backlight: lcd: Add LCD_POWER_ constants for power states Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 04/28] backlight: corgi_lcd: Use lcd power constants Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 05/28] backlight: hx8357: " Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 06/28] backlight: ili922x: " Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 07/28] backlight: ili9320: " Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 08/28] backlight: jornada720_lcd: Include <linux/io.h> for IOMEM() macro Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 09/28] backlight: jornada720_lcd: Use lcd power constants Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 10/28] backlight: l4f00242t03: " Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 11/28] backlight: lms283gf05: " Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 12/28] backlight: lms501kf03: Remove unnecessary include of <linux/backlight.h> Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 13/28] backlight: lms501kf03: Use lcd power constants Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 14/28] backlight: ltv350qv: " Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 15/28] backlight: otm3225a: " Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 16/28] backlight: platform_lcd: Remove include statement for <linux/backlight.h> Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 17/28] backlight: platform_lcd: Remove match_fb from struct plat_lcd_data Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 18/28] backlight: platform_lcd: Use lcd power constants Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 19/28] backlight: tdo24m: " Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 20/28] fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev Thomas Zimmermann
2024-08-20 9:22 ` [PATCH 21/28] fbdev: clps711x-fb: Use lcd power constants Thomas Zimmermann
2024-08-20 9:23 ` [PATCH 22/28] fbdev: imxfb: Replace check_fb in favor of struct fb_info.lcd_dev Thomas Zimmermann
2024-08-20 9:23 ` [PATCH 23/28] fbdev: imxfb: Use lcd power constants Thomas Zimmermann
2024-08-20 9:23 ` [PATCH 24/28] fbdev: omap: " Thomas Zimmermann
2024-08-20 9:23 ` [PATCH 25/28] HID: picoLCD: Replace check_fb in favor of struct fb_info.lcd_dev Thomas Zimmermann
2024-08-20 23:09 ` Jiri Kosina
2024-08-20 9:23 ` [PATCH 26/28] backlight: lcd: Replace check_fb with controls_device Thomas Zimmermann
2024-09-03 14:55 ` Daniel Thompson
2024-08-20 9:23 ` [PATCH 27/28] backlight: lcd: Remove struct fb_videomode from set_mode callback Thomas Zimmermann
2024-08-20 9:23 ` [PATCH 28/28] backlight: lcd: Do not include <linux/fb.h> in lcd header Thomas Zimmermann
2024-09-03 14:58 ` [PATCH 00/28] backlight: lcd: Remove fbdev dependencies Daniel Thompson
2024-09-05 13:35 ` Thomas Zimmermann
2024-09-09 8:25 ` Lee Jones
2024-09-05 13:37 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820093452.68270-2-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=bentiss@kernel.org \
--cc=bonbons@linux-vserver.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=jikos@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).